summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2000-03-26 23:16:07 +0000
committerAndrew Tridgell <tridge@samba.org>2000-03-26 23:16:07 +0000
commit4e7af2b3b580b2b580ca65bc96266d1a9b627f9d (patch)
tree56fa32b136f56ebe3f023c71d45d8d68384fb368
parentb18791b860e7d1f21f06e8b6b843ffbf1c1d101b (diff)
downloadsamba-4e7af2b3b580b2b580ca65bc96266d1a9b627f9d.tar.gz
samba-4e7af2b3b580b2b580ca65bc96266d1a9b627f9d.tar.bz2
samba-4e7af2b3b580b2b580ca65bc96266d1a9b627f9d.zip
when doing a "secure nbns" wack response and check with owner for a
multihomed registration we were sending the packet to the wrong host! We sent it to the person trying to register rather than to the person who currently holds the name. That means we were not secure and we could allow two people to register the same name. Jeremy, you may wish to merge this change into 2.0.X (This used to be commit 94ca1d1250d12918311a402cc689050ba1d06e24)
-rw-r--r--source3/nmbd/nmbd_winsserver.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/nmbd/nmbd_winsserver.c b/source3/nmbd/nmbd_winsserver.c
index e978718106..2b99a8ce53 100644
--- a/source3/nmbd/nmbd_winsserver.c
+++ b/source3/nmbd/nmbd_winsserver.c
@@ -1176,9 +1176,12 @@ is one of our (WINS server) names. Denying registration.\n", nmb_namestr(questio
* the recursion desired flag is not set (you were right Luke :-).
* This function should *only* be called from the WINS server
* code. JRA.
+ *
+ * Note that this packet is sent to the current owner of the name,
+ * not the person who sent the packet
*/
- query_name_from_wins_server( p->ip,
+ query_name_from_wins_server( namerec->data.ip[0],
question->name,
question->name_type,
wins_multihomed_register_query_success,