diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2003-01-02 13:01:44 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2003-01-02 13:01:44 +0000 |
| commit | 81c6415aa14d86630531d741a1c4c4f552cb84af (patch) | |
| tree | da89efea4789e7c22a71d29fc832b099bd0d728d | |
| parent | af3124067fcf73b5849d70469489654dce046617 (diff) | |
| download | samba-81c6415aa14d86630531d741a1c4c4f552cb84af.tar.gz samba-81c6415aa14d86630531d741a1c4c4f552cb84af.tar.bz2 samba-81c6415aa14d86630531d741a1c4c4f552cb84af.zip | |
Becouse these functions return a size_t, they can't return negitive numbers.
So a < 0 check is pointless, instead check against -1, which will be cast to
unsigned.
Andrew Bartlett
(This used to be commit c7e5797a95804d5779cdfc93795adcdf2fe82a59)
| -rw-r--r-- | source3/nsswitch/winbindd_pam.c | 6 | ||||
| -rw-r--r-- | source3/smbd/mangle_hash.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/source3/nsswitch/winbindd_pam.c b/source3/nsswitch/winbindd_pam.c index c5b68ea058..398b001f8b 100644 --- a/source3/nsswitch/winbindd_pam.c +++ b/source3/nsswitch/winbindd_pam.c @@ -185,13 +185,13 @@ enum winbindd_result winbindd_pam_auth_crap(struct winbindd_cli_state *state) goto done; } - if (pull_utf8_talloc(mem_ctx, &user, state->request.data.auth_crap.user) < 0) { + if (pull_utf8_talloc(mem_ctx, &user, state->request.data.auth_crap.user) == -1) { DEBUG(0, ("winbindd_pam_auth_crap: pull_utf8_talloc failed!\n")); } if (*state->request.data.auth_crap.domain) { char *dom = NULL; - if (pull_utf8_talloc(mem_ctx, &dom, state->request.data.auth_crap.domain) < 0) { + if (pull_utf8_talloc(mem_ctx, &dom, state->request.data.auth_crap.domain) == -1) { DEBUG(0, ("winbindd_pam_auth_crap: pull_utf8_talloc failed!\n")); } domain = dom; @@ -215,7 +215,7 @@ enum winbindd_result winbindd_pam_auth_crap(struct winbindd_cli_state *state) if (*state->request.data.auth_crap.workstation) { char *wrk = NULL; - if (pull_utf8_talloc(mem_ctx, &wrk, state->request.data.auth_crap.workstation) < 0) { + if (pull_utf8_talloc(mem_ctx, &wrk, state->request.data.auth_crap.workstation) == -1) { DEBUG(0, ("winbindd_pam_auth_crap: pull_utf8_talloc failed!\n")); } workstation = wrk; diff --git a/source3/smbd/mangle_hash.c b/source3/smbd/mangle_hash.c index 929cb0e07f..ac9c13dcac 100644 --- a/source3/smbd/mangle_hash.c +++ b/source3/smbd/mangle_hash.c @@ -730,7 +730,7 @@ static void name_map(char *OutName, BOOL need83, BOOL cache83) DEBUG(5,("name_map( %s, need83 = %s, cache83 = %s)\n", OutName, need83 ? "True" : "False", cache83 ? "True" : "False")); - if (push_ucs2_allocate(&OutName_ucs2, OutName) < 0) { + if (push_ucs2_allocate(&OutName_ucs2, OutName) == -1 ) { DEBUG(0, ("push_ucs2_allocate failed!\n")); return; } |