diff options
| author | Jeremy Allison <jra@samba.org> | 2007-08-17 01:55:58 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 12:29:53 -0500 |
| commit | 891fa216ead2c5001bc8c671639ae59be79b968b (patch) | |
| tree | 8c0035d87177c52060f089ec93509e585d790ca9 | |
| parent | a662a62e5a718065640e9b9f3c8f166638f4ec9a (diff) | |
| download | samba-891fa216ead2c5001bc8c671639ae59be79b968b.tar.gz samba-891fa216ead2c5001bc8c671639ae59be79b968b.tar.bz2 samba-891fa216ead2c5001bc8c671639ae59be79b968b.zip | |
r24501: Added bcc test for reply_tcon & removed Vl's comment :-).
Jeremy.
(This used to be commit 9d9ed41f2139051578c35f80112640cffb5f7608)
| -rw-r--r-- | source3/smbd/reply.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index a2ea35b115..ce3eebff99 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -442,12 +442,11 @@ void reply_tcon(connection_struct *conn, struct smb_request *req) START_PROFILE(SMBtcon); - /******************************************************************** - * Warning! I'm not sure that the inbuf length check is actually - * correct here. -- vl - * - * Jeremy, please check and remove this comment :-) - ********************************************************************/ + if (smb_buflen(req->inbuf) < 4) { + reply_nterror(req, NT_STATUS_INVALID_PARAMETER); + END_PROFILE(SMBtcon); + return; + } p = smb_buf(req->inbuf)+1; p += srvstr_pull_buf_talloc(req, req->inbuf, req->flags2, |