summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@sernet.de>2007-11-28 13:43:31 +0100
committerJeremy Allison <jra@samba.org>2007-11-28 09:45:40 -0800
commita605be73148ae0979c14263be1f969700f7055f6 (patch)
tree2b41cca8343da4ebc2d33753f1cbc5b588e27348
parentddcaaae4fff9ebb0de9f61599ec3fe058d8deaa4 (diff)
downloadsamba-a605be73148ae0979c14263be1f969700f7055f6.tar.gz
samba-a605be73148ae0979c14263be1f969700f7055f6.tar.bz2
samba-a605be73148ae0979c14263be1f969700f7055f6.zip
Add a warning for a potential bug I've run into
(This used to be commit 223352e32372f1b055298cfc6f2770043a845e3d)
-rw-r--r--source3/lib/tdb/common/traverse.c3
-rw-r--r--source3/lib/tdb/docs/README3
2 files changed, 6 insertions, 0 deletions
diff --git a/source3/lib/tdb/common/traverse.c b/source3/lib/tdb/common/traverse.c
index 6fc576a55a..27b2cfc54a 100644
--- a/source3/lib/tdb/common/traverse.c
+++ b/source3/lib/tdb/common/traverse.c
@@ -223,6 +223,9 @@ int tdb_traverse_read(struct tdb_context *tdb,
/*
a write style traverse - needs to get the transaction lock to
prevent deadlocks
+
+ WARNING: The data buffer given to the callback fn does NOT meet the
+ alignment restrictions malloc gives you.
*/
int tdb_traverse(struct tdb_context *tdb,
tdb_traverse_func fn, void *private_data)
diff --git a/source3/lib/tdb/docs/README b/source3/lib/tdb/docs/README
index b31ce36ab1..63fcf5e049 100644
--- a/source3/lib/tdb/docs/README
+++ b/source3/lib/tdb/docs/README
@@ -130,6 +130,9 @@ int tdb_traverse(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
a non-zero return value from fn() indicates that the traversal
should stop. Traversal callbacks may not start transactions.
+ WARNING: The data buffer given to the callback fn does NOT meet the
+ alignment restrictions malloc gives you.
+
----------------------------------------------------------------------
int tdb_traverse_read(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
TDB_DATA key, TDB_DATA dbuf, void *state), void *state);