summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2011-10-12 14:00:32 -0700
committerStefan Metzmacher <metze@samba.org>2011-10-13 12:22:23 +0200
commitd2a9e8df35be1516f22f0ef78356de6d4b02d4d3 (patch)
tree1026413b3274eda0507f015f634690e32ce56ae8
parent5dcce64bbd64d1fbc81fa1135e77c87316691017 (diff)
downloadsamba-d2a9e8df35be1516f22f0ef78356de6d4b02d4d3.tar.gz
samba-d2a9e8df35be1516f22f0ef78356de6d4b02d4d3.tar.bz2
samba-d2a9e8df35be1516f22f0ef78356de6d4b02d4d3.zip
Another part of the fix for Bug 8473 - smb2_find uses a hard coded max reply size of 0x10000 instead of smb2_max_trans.
Change the defaults and the documentation to reflect the 64k limit. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Oct 13 12:22:23 CEST 2011 on sn-devel-104
-rw-r--r--docs-xml/smbdotconf/protocol/smb2maxcredits.xml2
-rw-r--r--docs-xml/smbdotconf/protocol/smb2maxread.xml4
-rw-r--r--docs-xml/smbdotconf/protocol/smb2maxtrans.xml4
-rw-r--r--docs-xml/smbdotconf/protocol/smb2maxwrite.xml4
-rw-r--r--source3/include/local.h6
5 files changed, 10 insertions, 10 deletions
diff --git a/docs-xml/smbdotconf/protocol/smb2maxcredits.xml b/docs-xml/smbdotconf/protocol/smb2maxcredits.xml
index 310b8989ea..3cc219d1ec 100644
--- a/docs-xml/smbdotconf/protocol/smb2maxcredits.xml
+++ b/docs-xml/smbdotconf/protocol/smb2maxcredits.xml
@@ -11,5 +11,5 @@ parameter for SMB1. You should never need to set this parameter.
<para>The default is 8192 credits, which is the same as a Windows 2008R2 SMB2 server.</para>
</description>
-<value type="default">128</value>
+<value type="default">8192</value>
</samba:parameter>
diff --git a/docs-xml/smbdotconf/protocol/smb2maxread.xml b/docs-xml/smbdotconf/protocol/smb2maxread.xml
index f4bcb4bbf0..2666821648 100644
--- a/docs-xml/smbdotconf/protocol/smb2maxread.xml
+++ b/docs-xml/smbdotconf/protocol/smb2maxread.xml
@@ -8,10 +8,10 @@
<manvolnum>8</manvolnum></citerefentry> will return to a client, informing the client of the largest
size that may be returned by a single SMB2 read call.
</para>
-<para>The default is 1048576 bytes (1MB), which is the same as a Windows7 SMB2 server.</para>
+<para>The maximum is 65536 bytes (64KB), which is the same as a Windows Vista SMB2 server.</para>
</description>
<related>smb2 max write</related>
<related>smb2 max trans</related>
-<value type="default">1048576</value>
+<value type="default">65536</value>
</samba:parameter>
diff --git a/docs-xml/smbdotconf/protocol/smb2maxtrans.xml b/docs-xml/smbdotconf/protocol/smb2maxtrans.xml
index dd654f46d1..1c01ccce05 100644
--- a/docs-xml/smbdotconf/protocol/smb2maxtrans.xml
+++ b/docs-xml/smbdotconf/protocol/smb2maxtrans.xml
@@ -8,10 +8,10 @@
<manvolnum>8</manvolnum></citerefentry> will return to a client, informing the client of the largest
size of buffer that may be used in querying file meta-data via QUERY_INFO and related SMB2 calls.
</para>
-<para>The default is 1048576 bytes (1MB), which is the same as a Windows7 SMB2 server.</para>
+<para>The maximum is 65536 bytes (64KB), which is the same as a Windows Vista SMB2 server.</para>
</description>
<related>smb2 max read</related>
<related>smb2 max write</related>
-<value type="default">1048576</value>
+<value type="default">65536</value>
</samba:parameter>
diff --git a/docs-xml/smbdotconf/protocol/smb2maxwrite.xml b/docs-xml/smbdotconf/protocol/smb2maxwrite.xml
index cdbc47af47..a302a94a17 100644
--- a/docs-xml/smbdotconf/protocol/smb2maxwrite.xml
+++ b/docs-xml/smbdotconf/protocol/smb2maxwrite.xml
@@ -8,10 +8,10 @@
<manvolnum>8</manvolnum></citerefentry> will return to a client, informing the client of the largest
size that may be sent to the server by a single SMB2 write call.
</para>
-<para>The default is 1048576 bytes (1MB), which is the same as a Windows7 SMB2 server.</para>
+<para>The maximum is 65536 bytes (64KB), which is the same as a Windows Vista SMB2 server.</para>
</description>
<related>smb2 max read</related>
<related>smb2 max trans</related>
-<value type="default">1048576</value>
+<value type="default">65536</value>
</samba:parameter>
diff --git a/source3/include/local.h b/source3/include/local.h
index d71a72c2e5..203f257dca 100644
--- a/source3/include/local.h
+++ b/source3/include/local.h
@@ -232,9 +232,9 @@
#define CLIENT_NDR_PADDING_SIZE 8
#define SERVER_NDR_PADDING_SIZE 8
-#define DEFAULT_SMB2_MAX_READ (1024*1024)
-#define DEFAULT_SMB2_MAX_WRITE (1024*1024)
-#define DEFAULT_SMB2_MAX_TRANSACT (1024*1024)
+#define DEFAULT_SMB2_MAX_READ (64*1024)
+#define DEFAULT_SMB2_MAX_WRITE (64*1024)
+#define DEFAULT_SMB2_MAX_TRANSACT (64*1024)
#define DEFAULT_SMB2_MAX_CREDITS 8192
#define DEFAULT_SMB2_MAX_CREDIT_BITMAP_FACTOR 2