diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2002-10-26 00:59:21 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2002-10-26 00:59:21 +0000 |
| commit | dbfc2f42a2c4711f539364d3954b9b9c10dbddf5 (patch) | |
| tree | 7bfa38b98b198c7ac0b5bba80b1e7fd6e03da321 | |
| parent | 185a232ae0e8e9d459cbaa74fee96f7357cf5e6c (diff) | |
| download | samba-dbfc2f42a2c4711f539364d3954b9b9c10dbddf5.tar.gz samba-dbfc2f42a2c4711f539364d3954b9b9c10dbddf5.tar.bz2 samba-dbfc2f42a2c4711f539364d3954b9b9c10dbddf5.zip | |
Make sure that we always return False if the password change never returns.
(A stuck 'unix passowrd sync' was gettting reported as 'success', causing
all sorts of fun)
Andrew Bartlett
(This used to be commit b0d5745bb53b16e92160a6bdd2b984afb0e982ee)
| -rw-r--r-- | source3/libsmb/clirap.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/source3/libsmb/clirap.c b/source3/libsmb/clirap.c index 2064e14954..b4924fd773 100644 --- a/source3/libsmb/clirap.c +++ b/source3/libsmb/clirap.c @@ -343,13 +343,17 @@ BOOL cli_oem_change_password(struct cli_state *cli, const char *user, const char return False; } - if (cli_receive_trans(cli,SMBtrans, + if (!cli_receive_trans(cli,SMBtrans, &rparam, &rprcnt, &rdata, &rdrcnt)) { - if (rparam) - cli->rap_error = SVAL(rparam,0); + DEBUG(0,("cli_oem_change_password: Failed to recieve reply to password change for user %s\n", + user )); + return False; } - + + if (rparam) + cli->rap_error = SVAL(rparam,0); + SAFE_FREE(rparam); SAFE_FREE(rdata); |