diff options
| author | Jeremy Allison <jra@samba.org> | 2008-01-14 11:06:46 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2008-01-14 11:06:46 -0800 |
| commit | 19e4e99bfb02b8fa722883b04237ad714d402cb3 (patch) | |
| tree | 49f405f43e5297a2f3ea52c633ff1bcecdf282c6 | |
| parent | d35bda0ffd5bea57087dba9a6da8c20df8fa165c (diff) | |
| download | samba-19e4e99bfb02b8fa722883b04237ad714d402cb3.tar.gz samba-19e4e99bfb02b8fa722883b04237ad714d402cb3.tar.bz2 samba-19e4e99bfb02b8fa722883b04237ad714d402cb3.zip | |
From Alexander Bokovoy
names is a 'const char **names' here, passed from upper level. Passing
'names' as a talloc context will break things as 'names' is usually
likely is a local variable, not a talloc'd. And we want to have array
elements on a context of the array anyway.
Jeremy.
(This used to be commit 22a4129fabf70e01cc638c2f7347c28201838830)
| -rw-r--r-- | source3/lib/winbind_util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/lib/winbind_util.c b/source3/lib/winbind_util.c index 3cf068a6e0..14356b09cf 100644 --- a/source3/lib/winbind_util.c +++ b/source3/lib/winbind_util.c @@ -201,7 +201,7 @@ bool winbind_lookup_rids(TALLOC_CTX *mem_ctx, *types = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_rids); for(i=0; i<num_rids; i++) { - (*names)[i] = talloc_strdup(names, namelist[i]); + (*names)[i] = talloc_strdup(*names, namelist[i]); (*types)[i] = (enum lsa_SidType)name_types[i]; } |