summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2003-02-21 06:25:39 +0000
committerJeremy Allison <jra@samba.org>2003-02-21 06:25:39 +0000
commit2935d153763ca3f40de974418c479c4ef6cd4ec0 (patch)
tree7f0cec9263b4ac65be70cdb780bd7f7ef0b95652
parent6a46281dbb9c1f1f3278f199e812ba71bd0b45b8 (diff)
downloadsamba-2935d153763ca3f40de974418c479c4ef6cd4ec0.tar.gz
samba-2935d153763ca3f40de974418c479c4ef6cd4ec0.tar.bz2
samba-2935d153763ca3f40de974418c479c4ef6cd4ec0.zip
Added comments to make it clearer when we're assigning a pointer that it
must not be freed afterwards. Jeremy. (This used to be commit 80bad908c0235a57446c70b9632d3415c9d2fcf5)
-rw-r--r--source3/smbd/posix_acls.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
index a40fb4042f..93a57925f1 100644
--- a/source3/smbd/posix_acls.c
+++ b/source3/smbd/posix_acls.c
@@ -1000,8 +1000,16 @@ Deny entry after Allow entry. Failing to set on file %s.\n", fsp->fsp_name ));
return False;
}
+ /*
+ * We must not free current_ace here as its
+ * pointer is now owned by the dir_ace list.
+ */
current_ace = dup_ace;
} else {
+ /*
+ * We must not free current_ace here as its
+ * pointer is now owned by the dir_ace list.
+ */
current_ace = NULL;
}
}
@@ -1036,6 +1044,10 @@ Deny entry after Allow entry. Failing to set on file %s.\n", fsp->fsp_name ));
print_canon_ace( current_ace, 0);
}
all_aces_are_inherit_only = False;
+ /*
+ * We must not free current_ace here as its
+ * pointer is now owned by the file_ace list.
+ */
current_ace = NULL;
}