diff options
| author | Kai Blin <kai@samba.org> | 2009-06-25 19:38:51 +0200 |
|---|---|---|
| committer | Kai Blin <kai@samba.org> | 2009-06-25 19:38:51 +0200 |
| commit | 309924e5c1da5ee6bf14f48e9f7d10d4348b8f77 (patch) | |
| tree | e2030b2231613c716f4cb9975f0eb34f932cc26d | |
| parent | 946beae010145cc5066f81eb5e4b5e6392a37e2e (diff) | |
| download | samba-309924e5c1da5ee6bf14f48e9f7d10d4348b8f77.tar.gz samba-309924e5c1da5ee6bf14f48e9f7d10d4348b8f77.tar.bz2 samba-309924e5c1da5ee6bf14f48e9f7d10d4348b8f77.zip | |
s4 auth_winbind: Don't allocate the rids for the info3 structure within the loop
| -rw-r--r-- | source4/auth/ntlm/auth_winbind.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/source4/auth/ntlm/auth_winbind.c b/source4/auth/ntlm/auth_winbind.c index a41c37e27e..3905d00667 100644 --- a/source4/auth/ntlm/auth_winbind.c +++ b/source4/auth/ntlm/auth_winbind.c @@ -157,12 +157,12 @@ static NTSTATUS get_info3_from_wbcAuthUserInfo(TALLOC_CTX *mem_ctx, /* We already handled the first two, now take care of the rest */ info3->base.groups.count = info->num_sids - 2; - for (i = 2, j = 0; i < info->num_sids; ++i, ++j) { - rids = talloc_array(mem_ctx, struct samr_RidWithAttribute, - info3->base.groups.count); - NT_STATUS_HAVE_NO_MEMORY(rids); + rids = talloc_array(mem_ctx, struct samr_RidWithAttribute, + info3->base.groups.count); + NT_STATUS_HAVE_NO_MEMORY(rids); + for (i = 2, j = 0; i < info->num_sids; ++i, ++j) { rids[j].attributes = info->sids[i].attributes; dom_sid_split_rid(mem_ctx, (struct dom_sid2 *) &info->sids[i].sid, |