diff options
| author | Jeremy Allison <jra@samba.org> | 2013-01-25 10:21:48 -0800 |
|---|---|---|
| committer | David Disseldorp <ddiss@samba.org> | 2013-01-28 13:48:13 +0100 |
| commit | 34854ae58fb0fdeec7f27d1d6264b2035778ea6b (patch) | |
| tree | 9c579f6681131e6f258efc8021541f8c82ea2952 | |
| parent | 155fdc405ada674146afe577aa7228f6144d34b1 (diff) | |
| download | samba-34854ae58fb0fdeec7f27d1d6264b2035778ea6b.tar.gz samba-34854ae58fb0fdeec7f27d1d6264b2035778ea6b.tar.bz2 samba-34854ae58fb0fdeec7f27d1d6264b2035778ea6b.zip | |
Fix bug #9588 - ACLs are not inherited to directories for DFS shares.
We can return with NT_STATUS_OK in an error code path. This
has a really strange effect in that it prevents the ACL editor
in Windows XP from recursively changing ACE entries on sub-directories
after a change in a DFS-root share (we end up returning a path
that looks like: \\IPV4\share1\xptest/testdir with a mixture
of Windows and POSIX pathname separators).
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jan 28 13:48:13 CET 2013 on sn-devel-104
| -rw-r--r-- | source3/smbd/msdfs.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c index 4bf7aba34a..5388db9147 100644 --- a/source3/smbd/msdfs.c +++ b/source3/smbd/msdfs.c @@ -1031,6 +1031,19 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx, if (!NT_STATUS_EQUAL(status, NT_STATUS_PATH_NOT_COVERED)) { DEBUG(3,("get_referred_path: No valid referrals for path %s\n", dfs_path)); + if (NT_STATUS_IS_OK(status)) { + /* + * We are in an error path here (we + * know it's not a DFS path), but + * dfs_path_lookup() can return + * NT_STATUS_OK. Ensure we always + * return a valid error code. + * + * #9588 - ACLs are not inherited to directories + * for DFS shares. + */ + status = NT_STATUS_NOT_FOUND; + } goto err_exit; } |