summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2006-08-03 09:29:12 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 14:15:20 -0500
commit358b1b2ea6b240db695b00c2656af0ec47d44cc5 (patch)
tree8a81fdf1fd79bdfb094f70df6ec04a0bdac4f028
parent1057b4bea2351a898eb1b890612cefdfab98b743 (diff)
downloadsamba-358b1b2ea6b240db695b00c2656af0ec47d44cc5.tar.gz
samba-358b1b2ea6b240db695b00c2656af0ec47d44cc5.tar.bz2
samba-358b1b2ea6b240db695b00c2656af0ec47d44cc5.zip
r17381: - we don't need debug messages twice
- also user_info->mapped is maybe uninitialized in auth_password_check() as it we do the mapping in auth_password_check_send() that to Kai Blin <kai.blin@gmail.com> and valgrind to find this bug metze (This used to be commit d88aabef64316cebca46037b67dd2df7cfd4d482)
-rw-r--r--source4/auth/auth.c14
1 files changed, 2 insertions, 12 deletions
diff --git a/source4/auth/auth.c b/source4/auth/auth.c
index e478ac250b..5333c31e42 100644
--- a/source4/auth/auth.c
+++ b/source4/auth/auth.c
@@ -154,9 +154,6 @@ NTSTATUS auth_check_password(struct auth_context *auth_ctx,
struct auth_check_password_sync_state *sync_state;
NTSTATUS status;
- DEBUG(3, ("auth_check_password: Checking password for unmapped user [%s]\\[%s]@[%s]\n",
- user_info->client.domain_name, user_info->client.account_name, user_info->workstation_name));
-
sync_state = talloc_zero(auth_ctx, struct auth_check_password_sync_state);
NT_STATUS_HAVE_NO_MEMORY(sync_state);
@@ -170,13 +167,6 @@ NTSTATUS auth_check_password(struct auth_context *auth_ctx,
if (NT_STATUS_IS_OK(status)) {
*server_info = talloc_steal(mem_ctx, sync_state->server_info);
-
- DEBUG(5,("auth_check_password: authentication for user [%s\\%s] succeeded\n",
- (*server_info)->domain_name, (*server_info)->account_name));
- } else {
- DEBUG(2,("auth_check_password: authentication for user [%s\\%s] FAILED with error %s\n",
- user_info->mapped.domain_name, user_info->mapped.account_name,
- nt_errstr(status)));
}
talloc_free(sync_state);
@@ -339,12 +329,12 @@ NTSTATUS auth_check_password_recv(struct auth_check_password_request *req,
NT_STATUS_HAVE_NO_MEMORY(req);
if (NT_STATUS_IS_OK(req->status)) {
- DEBUG(5,("auth_check_password: %s authentication for user [%s\\%s] succeeded\n",
+ DEBUG(5,("auth_check_password_recv: %s authentication for user [%s\\%s] succeeded\n",
req->method->ops->name, req->server_info->domain_name, req->server_info->account_name));
*server_info = talloc_steal(mem_ctx, req->server_info);
} else {
- DEBUG(2,("auth_check_password: %s authentication for user [%s\\%s] FAILED with error %s\n",
+ DEBUG(2,("auth_check_password_recv: %s authentication for user [%s\\%s] FAILED with error %s\n",
(req->method ? req->method->ops->name : "NO_METHOD"),
req->user_info->mapped.domain_name,
req->user_info->mapped.account_name,