summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2009-02-13 10:08:37 +0100
committerVolker Lendecke <vl@samba.org>2009-02-13 10:20:51 +0100
commit6e19b22c5a208351e570fc09fbf2f0b9eb975b2e (patch)
tree4825a8b010586fd52d816c5956b12f341ba609b2
parent4d100f2f6a832a70f9e481904ece4f7c9f090730 (diff)
downloadsamba-6e19b22c5a208351e570fc09fbf2f0b9eb975b2e.tar.gz
samba-6e19b22c5a208351e570fc09fbf2f0b9eb975b2e.tar.bz2
samba-6e19b22c5a208351e570fc09fbf2f0b9eb975b2e.zip
Fix Coverity ID 744
This was marked as a resource leak. This change makes the code a bit clearer that we always free error_string.
-rw-r--r--source3/utils/ntlm_auth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/utils/ntlm_auth.c b/source3/utils/ntlm_auth.c
index bdc75a16f9..ab5a743f9d 100644
--- a/source3/utils/ntlm_auth.c
+++ b/source3/utils/ntlm_auth.c
@@ -1817,7 +1817,6 @@ static void manage_ntlm_server_1_request(struct ntlm_auth_state *state,
x_fprintf(x_stdout, "Authenticated: No\n");
x_fprintf(x_stdout, "Authentication-Error: %s\n.\n", error_string);
- SAFE_FREE(error_string);
} else {
static char zeros[16];
char *hex_lm_key;
@@ -1845,6 +1844,7 @@ static void manage_ntlm_server_1_request(struct ntlm_auth_state *state,
TALLOC_FREE(hex_user_session_key);
}
}
+ SAFE_FREE(error_string);
}
/* clear out the state */
challenge = data_blob_null;