summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitay Isaacs <amitay@gmail.com>2012-12-06 16:04:32 +1100
committerAndrew Bartlett <abartlet@samba.org>2013-05-30 10:43:42 +1000
commitb5c3ec0abc22145841b9b528cb55ec381e9c0d06 (patch)
tree5b0900e25cd2720cbf2e20fb006af958f8a56fb4
parent3f24d694e7e2190d30a17bc13a79a36b49711531 (diff)
downloadsamba-b5c3ec0abc22145841b9b528cb55ec381e9c0d06.tar.gz
samba-b5c3ec0abc22145841b9b528cb55ec381e9c0d06.tar.bz2
samba-b5c3ec0abc22145841b9b528cb55ec381e9c0d06.zip
s4-rpc: dnsserver: Fix removal of trailing '.' in soa mname
Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--source4/rpc_server/dnsserver/dnsdata.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index f0584a9811..87b7d87ae3 100644
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -412,9 +412,9 @@ struct dnsp_DnssrvRpcRecord *dns_to_dnsp_copy(TALLOC_CTX *mem_ctx, struct DNS_RP
len = dns->data.soa.NamePrimaryServer.len;
if (dns->data.soa.NamePrimaryServer.str[len-1] == '.') {
- dnsp->data.soa.mname = talloc_strdup(mem_ctx, dns->data.soa.NamePrimaryServer.str);
- } else {
dnsp->data.soa.mname = talloc_strndup(mem_ctx, dns->data.soa.NamePrimaryServer.str, len-1);
+ } else {
+ dnsp->data.soa.mname = talloc_strdup(mem_ctx, dns->data.soa.NamePrimaryServer.str);
}
len = dns->data.soa.ZoneAdministratorEmail.len;