diff options
| author | Stefan Metzmacher <metze@samba.org> | 2010-03-25 14:10:25 +0100 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2010-03-29 18:11:15 +0200 |
| commit | 5f8fc63515a02aaf55719cb8d3be8ce695178fe9 (patch) | |
| tree | ebe5bf2ed9e6fce15cd5ecd8a933206e21c8682b | |
| parent | b862351da8624df893ec77e020a456c1d23c58ed (diff) | |
| download | samba-5f8fc63515a02aaf55719cb8d3be8ce695178fe9.tar.gz samba-5f8fc63515a02aaf55719cb8d3be8ce695178fe9.tar.bz2 samba-5f8fc63515a02aaf55719cb8d3be8ce695178fe9.zip | |
s3:rpc_transport_np: add comment about bad usage in a destructor
metze
| -rw-r--r-- | source3/rpc_client/rpc_transport_np.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/rpc_client/rpc_transport_np.c b/source3/rpc_client/rpc_transport_np.c index 5b6a2d6ae0..96a8988e64 100644 --- a/source3/rpc_client/rpc_transport_np.c +++ b/source3/rpc_client/rpc_transport_np.c @@ -34,7 +34,8 @@ static int rpc_transport_np_state_destructor(struct rpc_transport_np_state *s) DEBUG(10, ("socket was closed, no need to send close request.\n")); return 0; } - + + /* TODO: do not use a sync call with a destructor!!! */ if (!NT_STATUS_IS_OK(cli_close(s->cli, s->fnum))) { DEBUG(1, ("rpc_transport_np_state_destructor: cli_close " "failed on pipe %s. Error was %s\n", s->pipe_name, |