ntdb: enhancement to allow direct access to the ntdb map during expansion.

This means keeping the old mmap around when we expand the database.
We could revert to read/write, except for platforms with incoherent
mmap (ie. OpenBSD), where we need to use mmap for all accesses.

Thus we keep a linked list of old maps, and unmap them when the last access
finally goes away.

This is required if we want ntdb_parse_record() callbacks to be able
to expand the database.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

1 files changed, 0 insertions, 3 deletions

diff --git a/lib/ntdb/free.c b/lib/ntdb/free.c
index 971436f5a3..470c3765d9 100644
--- a/lib/ntdb/free.c
+++ b/lib/ntdb/free.c
@@ -958,9 +958,6 @@ ntdb_off_t alloc(struct ntdb_context *ntdb, size_t keylen, size_t datalen,
 {
 	ntdb_off_t off;
 
-	/* We can't hold pointers during this: we could unmap! */
-	assert(!ntdb->direct_access);
-
 	for (;;) {
 		enum NTDB_ERROR ecode;
 		off = get_free(ntdb, keylen, datalen, growing, magic);