diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-06-19 12:43:09 +0930 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-06-19 05:38:07 +0200 |
commit | b888bc4316f3f9c74b6768ddb1db1ec8fbac975e (patch) | |
tree | 265f0b7f53ceb5959dd32bd5698f8bb4665bfe17 /lib/ntdb/hash.c | |
parent | 8fdd20b22f6b27b616b5b3a2285a267ffae0a262 (diff) | |
download | samba-b888bc4316f3f9c74b6768ddb1db1ec8fbac975e.tar.gz samba-b888bc4316f3f9c74b6768ddb1db1ec8fbac975e.tar.bz2 samba-b888bc4316f3f9c74b6768ddb1db1ec8fbac975e.zip |
ntdb: optimize ntdb_fetch.
We access the key on lookup, then access the data in the caller. It
makes more sense to access both at once. We also put in a likely()
for the case where the hash is not chained.
Before:
Adding 1000 records: 3644-3724(3675) ns (129656 bytes)
Finding 1000 records: 1596-1696(1622) ns (129656 bytes)
Missing 1000 records: 1409-1525(1452) ns (129656 bytes)
Traversing 1000 records: 1636-1747(1668) ns (129656 bytes)
Deleting 1000 records: 3138-3223(3175) ns (129656 bytes)
Re-adding 1000 records: 3278-3414(3329) ns (129656 bytes)
Appending 1000 records: 5396-5529(5426) ns (253312 bytes)
Churning 1000 records: 9451-10095(9584) ns (253312 bytes)
smbtorture results (--entries=1000)
ntdb speed 183881-191112(188223) ops/sec
After:
Adding 1000 records: 3590-3701(3640) ns (129656 bytes)
Finding 1000 records: 1539-1605(1566) ns (129656 bytes)
Missing 1000 records: 1398-1440(1413) ns (129656 bytes)
Traversing 1000 records: 1629-2015(1710) ns (129656 bytes)
Deleting 1000 records: 3118-3236(3163) ns (129656 bytes)
Re-adding 1000 records: 3235-3355(3275) ns (129656 bytes)
Appending 1000 records: 5335-5444(5385) ns (253312 bytes)
Churning 1000 records: 9350-9955(9494) ns (253312 bytes)
smbtorture results (--entries=1000)
ntdb speed 180559-199981(195106) ops/sec
Diffstat (limited to 'lib/ntdb/hash.c')
-rw-r--r-- | lib/ntdb/hash.c | 37 |
1 files changed, 23 insertions, 14 deletions
diff --git a/lib/ntdb/hash.c b/lib/ntdb/hash.c index 69192a119b..ad1196ecde 100644 --- a/lib/ntdb/hash.c +++ b/lib/ntdb/hash.c @@ -33,7 +33,8 @@ uint32_t ntdb_hash(struct ntdb_context *ntdb, const void *ptr, size_t len) static ntdb_bool_err key_matches(struct ntdb_context *ntdb, const struct ntdb_used_record *rec, ntdb_off_t off, - const NTDB_DATA *key) + const NTDB_DATA *key, + const char **rptr) { ntdb_bool_err ret = false; const char *rkey; @@ -43,14 +44,20 @@ static ntdb_bool_err key_matches(struct ntdb_context *ntdb, return ret; } - rkey = ntdb_access_read(ntdb, off + sizeof(*rec), key->dsize, false); + rkey = ntdb_access_read(ntdb, off + sizeof(*rec), + key->dsize + rec_data_length(rec), false); if (NTDB_PTR_IS_ERR(rkey)) { return (ntdb_bool_err)NTDB_PTR_ERR(rkey); } - if (memcmp(rkey, key->dptr, key->dsize) == 0) - ret = true; - else - ntdb->stats.compare_wrong_keycmp++; + if (memcmp(rkey, key->dptr, key->dsize) == 0) { + if (rptr) { + *rptr = rkey; + } else { + ntdb_access_release(ntdb, rkey); + } + return true; + } + ntdb->stats.compare_wrong_keycmp++; ntdb_access_release(ntdb, rkey); return ret; } @@ -61,6 +68,7 @@ static ntdb_bool_err match(struct ntdb_context *ntdb, const NTDB_DATA *key, ntdb_off_t val, struct ntdb_used_record *rec, + const char **rptr, const ntdb_off_t **mapped) { ntdb_off_t off; @@ -87,7 +95,7 @@ static ntdb_bool_err match(struct ntdb_context *ntdb, return (ntdb_bool_err)ecode; } - return key_matches(ntdb, rec, off, key); + return key_matches(ntdb, rec, off, key, rptr); } static bool is_chain(ntdb_off_t val) @@ -107,10 +115,11 @@ static ntdb_off_t hbucket_off(ntdb_off_t base, ntdb_len_t idx) * If not found, the return value is 0. * If found, the return value is the offset, and *rec is the record. */ ntdb_off_t find_and_lock(struct ntdb_context *ntdb, - NTDB_DATA key, - int ltype, - struct hash_info *h, - struct ntdb_used_record *rec) + NTDB_DATA key, + int ltype, + struct hash_info *h, + struct ntdb_used_record *rec, + const char **rptr) { ntdb_off_t off, val; const ntdb_off_t *arr = NULL; @@ -140,9 +149,9 @@ ntdb_off_t find_and_lock(struct ntdb_context *ntdb, } /* Directly in hash table? */ - if (!is_chain(val)) { + if (!likely(is_chain(val))) { if (val) { - berr = match(ntdb, h->h, &key, val, rec, NULL); + berr = match(ntdb, h->h, &key, val, rec, rptr, NULL); if (berr < 0) { ecode = NTDB_OFF_TO_ERR(berr); goto fail; @@ -195,7 +204,7 @@ ntdb_off_t find_and_lock(struct ntdb_context *ntdb, found_empty = true; } } else { - berr = match(ntdb, h->h, &key, val, rec, &arr); + berr = match(ntdb, h->h, &key, val, rec, rptr, &arr); if (berr < 0) { ecode = NTDB_OFF_TO_ERR(berr); if (arr) { |