diff options
| author | Volker Lendecke <vl@samba.org> | 2011-03-05 12:57:59 +0100 |
|---|---|---|
| committer | Volker Lendecke <vlendec@samba.org> | 2011-03-05 14:08:37 +0100 |
| commit | dcbfb6fc0b9050168e2010673caccb7ec8807bd1 (patch) | |
| tree | 175575b07e844d04351107598c342002084e1542 /lib/socket_wrapper/socket_wrapper.h | |
| parent | f1a5109565cc178242acd33d9d1eb2fd80229e2c (diff) | |
| download | samba-dcbfb6fc0b9050168e2010673caccb7ec8807bd1.tar.gz samba-dcbfb6fc0b9050168e2010673caccb7ec8807bd1.tar.bz2 samba-dcbfb6fc0b9050168e2010673caccb7ec8807bd1.zip | |
s3: Fix a memory leak in check_sam_security_info3
Abartlet, this commit makes check_sam_security_info3 use talloc_tos() and also
cleans up the temporary talloc stackframe.
The old code created a temporary talloc context off "mem_ctx" but failed to
clean up the tmp_ctx in all but one return paths.
talloc_stackframe()/talloc_tos() is designed as a defense against exactly this
error: Even if we failed to free the frame when returning from the routine, it
would be cleaned up very soon, in our main event loop.
Please check this patch!
Thanks,
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 14:08:37 CET 2011 on sn-devel-104
Diffstat (limited to 'lib/socket_wrapper/socket_wrapper.h')
0 files changed, 0 insertions, 0 deletions