pytalloc: fixed py_talloc_steal()

py_talloc_steal() was implemented as a macro which evaluated it's 2nd
argument twice. It was often called via a macro with a 2nd argument
that was a function call, for example an allocation in
py_talloc_new(). This meant it allocated memory twice, and leaked one
of them.

This re-implements py_talloc_steal() as a function, so that it only
does the allocation once.

1 files changed, 8 insertions, 0 deletions

diff --git a/lib/talloc/pytalloc.c b/lib/talloc/pytalloc.c
index 4e0b2eca2b..92b7b94052 100644
--- a/lib/talloc/pytalloc.c
+++ b/lib/talloc/pytalloc.c
@@ -52,6 +52,14 @@ PyObject *py_talloc_steal_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx,
 	return (PyObject *)ret;
 }
 
+/**
+ * Import an existing talloc pointer into a Python object.
+ */
+PyObject *py_talloc_steal(PyTypeObject *py_type, void *ptr)
+{
+	return py_talloc_steal_ex(py_type, ptr, ptr);
+}
+
 
 /**
  * Import an existing talloc pointer into a Python object, leaving the