summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorSean Finney <seanius@seanius.net>2011-05-20 08:12:08 +0000
committerMatthias Dieter Wallnöfer <mdw@samba.org>2011-05-25 19:22:13 +0200
commit0f8018676a6cb33238d506338d4fbb8b683550d3 (patch)
tree1e2dc4bb4a4f3179ce795e417bbd48f4474e7dd7 /lib
parentb58534f1fca27e3e72f4f4107538ec05734bd42a (diff)
downloadsamba-0f8018676a6cb33238d506338d4fbb8b683550d3.tar.gz
samba-0f8018676a6cb33238d506338d4fbb8b683550d3.tar.bz2
samba-0f8018676a6cb33238d506338d4fbb8b683550d3.zip
Fix numerous missing dependencies in WAF build scripts
With the recent consolidation of code between s3 and s4, a number of new dependencies have been implicitly introduced. For example, previous s3 code gained an implicit dependency on talloc after the charset related consolidation (lib/util/charset/charset.h now includes talloc.h). When building against the embedded version of talloc this isn't a problem since the paths are automatically added to the search path, but when building against the external libraries build failures will occur for all components that don't directly or indirectly include talloc as a dependency. Since charset.h is included from util.h, which in turn is included from includes.h, this means most of the codebase (s3 and s4) has such an undeclared dependency. Therefore, samba-util-common and samba-util have been added as dependencies to the s3 and s4 code respectively, for all cases where the source would otherwise fail to build. Additionally, a few other dependencies are added in specific wscript_build files to address similar dependency-related problems. https://bugzilla.samba.org/show_bug.cgi?id=8128 Signed-off-by: Sean Finney <seanius@seanius.net> Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Wed May 25 19:22:13 CEST 2011 on sn-devel-104
Diffstat (limited to 'lib')
-rw-r--r--lib/util/charset/wscript_build4
-rwxr-xr-xlib/util/wscript_build4
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/util/charset/wscript_build b/lib/util/charset/wscript_build
index 3b29ace6d3..1f2c8dfa7a 100644
--- a/lib/util/charset/wscript_build
+++ b/lib/util/charset/wscript_build
@@ -7,8 +7,8 @@ bld.SAMBA_SUBSYSTEM('ICONV_WRAPPER',
bld.SAMBA_SUBSYSTEM('CHARSET',
public_headers='charset.h',
source='codepoints.c convert_string.c util_str.c util_unistr_w.c charcnv.c pull_push.c util_unistr.c',
- deps='DYNCONFIG ICONV_WRAPPER'
- )
+ deps='DYNCONFIG ICONV_WRAPPER',
+ public_deps='talloc')
bld.SAMBA_MODULE('charset_weird',
subsystem='CHARSET',
diff --git a/lib/util/wscript_build b/lib/util/wscript_build
index 740e68b6f0..3092b6ccbb 100755
--- a/lib/util/wscript_build
+++ b/lib/util/wscript_build
@@ -8,10 +8,10 @@ common_util_sources = '''talloc_stack.c smb_threads.c xfile.c data_blob.c
util_str.c util_str_common.c substitute.c ms_fnmatch.c'''
common_util_headers = 'debug.h'
-common_util_public_deps = 'talloc pthread LIBCRYPTO'
+common_util_public_deps = 'talloc pthread LIBCRYPTO CHARSET'
s4_util_sources = '''dprintf.c parmlist.c'''
s4_util_deps = 'DYNCONFIG'
-s4_util_public_deps = 'talloc CHARSET execinfo uid_wrapper'
+s4_util_public_deps = 'talloc execinfo uid_wrapper'
s4_util_public_headers = 'attr.h byteorder.h data_blob.h memory.h safe_string.h time.h talloc_stack.h xfile.h dlinklist.h util.h string_wrappers.h'
s4_util_header_path = [ ('dlinklist.h util.h', '.'), ('*', 'util') ]