summaryrefslogtreecommitdiff
path: root/release-scripts
diff options
context:
space:
mode:
authorSimo Sorce <idra@samba.org>2011-08-16 09:30:28 -0400
committerSimo Sorce <idra@samba.org>2011-08-21 09:05:05 -0400
commitee0c69a25e7a0dca0c54989b1d6887a114d93ed4 (patch)
treee14825b26c28a5d196c9aadad0c73f577e1f2e3d /release-scripts
parent07238713722c7454b87ed9c99d65c37ad3bcee85 (diff)
downloadsamba-ee0c69a25e7a0dca0c54989b1d6887a114d93ed4.tar.gz
samba-ee0c69a25e7a0dca0c54989b1d6887a114d93ed4.tar.bz2
samba-ee0c69a25e7a0dca0c54989b1d6887a114d93ed4.zip
s3-prefork: do not use a lock_fd, just race on accept()
We used a lock mimicking what apache does for preforked children. But it doesn't work properly in our case because we do not stop once a request has been served. Clients are allowed to perform multiple requests and keep the connection open. This means that if we allow multiple clients per children, then a child could take the lock and then be asked to do a long or even locking operation by a client it already is serving. This woulkd cause the whole server to deadlock, as the child is now busy and also holding on the lock. Using a race on accept() by having a tevent_fd on the listening socket wait for read events we never deadlock. At most we cause a bit of contention among children. But in the generic case connections are much less frequent for us as clients tend to be long lived. So the little contention we may have is not a big deal. Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Simo Sorce <idra@samba.org>
Diffstat (limited to 'release-scripts')
0 files changed, 0 insertions, 0 deletions