diff options
| author | Jeremy Allison <jra@samba.org> | 2012-12-21 15:16:10 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2012-12-22 02:08:33 +0100 |
| commit | c1fb37d7bec1dd720f3eccbd0b490b6a335ca288 (patch) | |
| tree | 2ffa117fb5a67a81d3aa597163e37999bdf1b870 /selftest | |
| parent | b1548fd944578d845c5aaf88a528cf5a60df0c62 (diff) | |
| download | samba-c1fb37d7bec1dd720f3eccbd0b490b6a335ca288.tar.gz samba-c1fb37d7bec1dd720f3eccbd0b490b6a335ca288.tar.bz2 samba-c1fb37d7bec1dd720f3eccbd0b490b6a335ca288.zip | |
Recent coverity changes added directory_create_or_exist() checks to many directories.
These may not be needed, but in the meantime - ensure "make test" works again
by chmod'ing the created test directories from 0777 to 0755.
Reviewed-By: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104
Diffstat (limited to 'selftest')
| -rwxr-xr-x | selftest/target/Samba3.pm | 7 | ||||
| -rw-r--r-- | selftest/target/Samba4.pm | 6 |
2 files changed, 13 insertions, 0 deletions
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index ea2e21d6f3..adca52fdfa 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -765,6 +765,13 @@ sub provision($$$$$$) mkdir($_, 0777) foreach(@dirs); ## + ## lockdir and piddir must be 0755 + ## + chmod 0755, $lockdir; + chmod 0755, $piddir; + + + ## ## create ro and msdfs share layout ## diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index 5988b83642..ba37504651 100644 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -555,6 +555,12 @@ sub provision_raw_step1($$) mkdir($_, 0777) foreach (@{$ctx->{directories}}); + ## + ## lockdir and piddir must be 0755 + ## + chmod 0755, $ctx->{lockdir}; + chmod 0755, $ctx->{piddir}; + unless (open(CONFFILE, ">$ctx->{smb_conf}")) { warn("can't open $ctx->{smb_conf}$?"); return undef; |