this is a big global fix for the ptr = Realloc(ptr, size) bug.

many possible mem leaks, and segfaults fixed.

someone should port this fix to 2.2 also.
(This used to be commit fa8e55b8b465114ce209344965c1ca0333b84db9)

1 files changed, 7 insertions, 3 deletions

diff --git a/source3/aparser/parser.c b/source3/aparser/parser.c
index c2348b84f9..0c7153e1fb 100644
--- a/source3/aparser/parser.c
+++ b/source3/aparser/parser.c
@@ -460,8 +460,12 @@ realloc some memory for a parse structure
  ********************************************************************/
 BOOL io_realloc(char *name, io_struct *ps, void **ptr, unsigned size)
 {
-	(*ptr) = (void *)Realloc(*ptr, size);
-	if (*ptr) return True;
-	return False;
+	BOOL ret = True;
+	void *tp;
+
+	tp = (void *)Realloc(*ptr, size);
+	if (tp) *ptr = tp;
+	else ret = False;
+	return ret;
 }