diff options
| author | Martin Pool <mbp@samba.org> | 2003-01-20 00:53:35 +0000 |
|---|---|---|
| committer | Martin Pool <mbp@samba.org> | 2003-01-20 00:53:35 +0000 |
| commit | 115f3d847057f1314465376a730f62b925059912 (patch) | |
| tree | a0698b8bb5a04241ca772351557e7e4d3e04d332 /source3/client/smbmount.c | |
| parent | a45db02a82a42d6ac616c3a1efe73272ccbd69b5 (diff) | |
| download | samba-115f3d847057f1314465376a730f62b925059912.tar.gz samba-115f3d847057f1314465376a730f62b925059912.tar.bz2 samba-115f3d847057f1314465376a730f62b925059912.zip | |
Add FIXME about dodgy argument parser.
(This used to be commit a58028330849dbb1706793fdc6e36161f7baebed)
Diffstat (limited to 'source3/client/smbmount.c')
| -rw-r--r-- | source3/client/smbmount.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/source3/client/smbmount.c b/source3/client/smbmount.c index 2c70f3ff50..f90c56859f 100644 --- a/source3/client/smbmount.c +++ b/source3/client/smbmount.c @@ -687,6 +687,17 @@ static void parse_mount_smb(int argc, char **argv) int val; char *p; + /* FIXME: This function can silently fail if the arguments are + * not in the expected order. + + > The arguments syntax of smbmount 2.2.3a (smbfs of Debian stable) + > requires that one gives "-o" before further options like username=... + > . Without -o, the username=.. setting is *silently* ignored. I've + > spent about an hour trying to find out why I couldn't log in now.. + + */ + + if (argc < 2 || argv[1][0] == '-') { usage(); exit(1); |