Ok - this is a *BIG* change - but it fixes the problems with static strings

in the RPC code. This change was prompted by trying to save a long (>256)
character comment in the printer properties page.

The new system associates a TALLOC_CTX with the pipe struct, and frees
the pool on return of a complete PDU.

A global TALLOC_CTX is used for the odd buffer allocated in the BUFFERxx
code, and is freed in the main loop.

This code works with insure, and seems to be free of memory leaks and
crashes (so far) but there are probably the occasional problem with
code that uses UNISTRxx structs on the stack and expects them to contain
storage without doing a init_unistrXX().

This means that rpcclient will probably be horribly broken.
A TALLOC_CTX also needed associating with the struct cli_state also,
to make the prs_xx code there work.

The main interface change is the addition of a TALLOC_CTX to the
prs_init calls - used for dynamic allocation in the prs_XXX calls.

Now this is in place it should make dynamic allocation of all RPC
memory on unmarshall *much* easier to fix.

Jeremy.
(This used to be commit 0ff2ce543ee54f7364e6d839db6d06e7ef1edcf4)

1 files changed, 14 insertions, 12 deletions

diff --git a/source3/include/ntdomain.h b/source3/include/ntdomain.h
index fe6704c2ad..7a47f6150e 100644
--- a/source3/include/ntdomain.h
+++ b/source3/include/ntdomain.h
@@ -33,6 +33,8 @@
 
 #include "rpc_creds.h"
 
+#include "talloc.h"
+
 /*
  * A bunch of stuff that was put into smb.h
  * in the NTDOM branch - it didn't belong there.
@@ -64,6 +66,7 @@ typedef struct _prs_struct
 	uint32 buffer_size; /* Current allocated size of the buffer. */
 	uint32 grow_size; /* size requested via prs_grow() calls */
 	char *data_p; /* The buffer itself. */
+	TALLOC_CTX *mem_ctx; /* When unmarshalling, use this.... */
 } prs_struct;
 
 /*
@@ -131,17 +134,17 @@ typedef struct _input_data {
 
 struct msrpc_state
 {
-	fstring pipe_name;
-	struct user_creds usr;
-	struct ntdom_info nt;
+    fstring pipe_name;
+    struct user_creds usr;
+    struct ntdom_info nt;
 
-	int fd;
-	BOOL redirect;
-	BOOL initialised;
-	char *inbuf;
-	char *outbuf;
+    int fd;
+    BOOL redirect;
+    BOOL initialised;
+    char *inbuf;
+    char *outbuf;
 
-	uint32 pid;
+    uint32 pid;
 };
 
 typedef struct pipes_struct
@@ -208,9 +211,8 @@ typedef struct pipes_struct
            data that can be sent in the initial reply. */
 	int max_trans_reply;
 
-	/* remote, server-side rpc redirection */
-	struct msrpc_state *m;
-
+	/* talloc context to use when allocating memory on this pipe. */
+	TALLOC_CTX *mem_ctx;
 } pipes_struct;
 
 struct api_struct