diff options
| author | Volker Lendecke <vl@samba.org> | 2009-06-19 16:00:23 +0200 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2009-06-19 16:25:10 +0200 |
| commit | 8d1b81926d95f149936f3eb0a50355707d6c8bfa (patch) | |
| tree | 0c884a06969c0eb00e88fc03cb3c696f0a3a7dc3 /source3/include | |
| parent | 4ad43a21344b43f1c9fe459165098bcab1695711 (diff) | |
| download | samba-8d1b81926d95f149936f3eb0a50355707d6c8bfa.tar.gz samba-8d1b81926d95f149936f3eb0a50355707d6c8bfa.tar.bz2 samba-8d1b81926d95f149936f3eb0a50355707d6c8bfa.zip | |
Fix Coverity IDs 922 and 933
In copy_internals(), if the !CAN_WRITE(conn) kicks in, we end up
dereferencing a NULL smb_filename.
This adds a simple protection around it.
Tim, please check!
Volker
Diffstat (limited to 'source3/include')
| -rw-r--r-- | source3/include/proto.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/include/proto.h b/source3/include/proto.h index 74406fdeac..ffd2858594 100644 --- a/source3/include/proto.h +++ b/source3/include/proto.h @@ -6372,7 +6372,7 @@ NTSTATUS create_synthetic_smb_fname_split(TALLOC_CTX *ctx, const char *fname, SMB_STRUCT_STAT *psbuf, struct smb_filename **smb_fname_out); -char *smb_fname_str_dbg(const struct smb_filename *smb_fname); +const char *smb_fname_str_dbg(const struct smb_filename *smb_fname); NTSTATUS copy_smb_filename(TALLOC_CTX *ctx, const struct smb_filename *smb_fname_in, struct smb_filename **smb_fname_out); |