diff options
author | Jeremy Allison <jra@samba.org> | 2003-10-22 23:38:20 +0000 |
---|---|---|
committer | Jeremy Allison <jra@samba.org> | 2003-10-22 23:38:20 +0000 |
commit | bb0598faf58679a7ad26a1caab8eadb154a07ae2 (patch) | |
tree | beee6b610df4ad7660cb174c86773bd9c747682c /source3/include | |
parent | 3531647574ba61ce69969c501fbc82937a4d4dfa (diff) | |
download | samba-bb0598faf58679a7ad26a1caab8eadb154a07ae2.tar.gz samba-bb0598faf58679a7ad26a1caab8eadb154a07ae2.tar.bz2 samba-bb0598faf58679a7ad26a1caab8eadb154a07ae2.zip |
Put strcasecmp/strncasecmp on the banned list (except for needed calls
in iconv.c and nsswitch/). Using them means you're not thinking about multibyte at
all and I really want to discourage that.
Jeremy.
(This used to be commit d7e35dfb9283d560d0ed2ab231f36ed92767dace)
Diffstat (limited to 'source3/include')
-rw-r--r-- | source3/include/safe_string.h | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/source3/include/safe_string.h b/source3/include/safe_string.h index 07578b2424..cb3f37c484 100644 --- a/source3/include/safe_string.h +++ b/source3/include/safe_string.h @@ -47,6 +47,20 @@ #endif /* sprintf */ #define sprintf __ERROR__XX__NEVER_USE_SPRINTF__; +/* + * strcasecmp/strncasecmp aren't an error, but it means you're not thinking about + * multibyte. Don't use them. JRA. + */ +#ifdef strcasecmp +#undef strcasecmp +#endif +#define strcasecmp __ERROR__XX__NEVER_USE_STRCASECMP__; + +#ifdef strncasecmp +#undef strncasecmp +#endif +#define strncasecmp __ERROR__XX__NEVER_USE_STRCASECMP__; + #endif /* !_SPLINT_ */ #ifdef DEVELOPER |