diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2002-01-18 02:37:55 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2002-01-18 02:37:55 +0000 |
| commit | 1fb9ccc4e2a91bf7124fba076ffa5458a1cbf404 (patch) | |
| tree | e62b44816d89c4b8ad6ce5ccaf3050afc148ce20 /source3/lib | |
| parent | 9d05373a767cef2e841640f192e74da37fbb099f (diff) | |
| download | samba-1fb9ccc4e2a91bf7124fba076ffa5458a1cbf404.tar.gz samba-1fb9ccc4e2a91bf7124fba076ffa5458a1cbf404.tar.bz2 samba-1fb9ccc4e2a91bf7124fba076ffa5458a1cbf404.zip | |
This is the 'winbind default domain' patch from Alexander Bokovoy
<a.bokovoy@sam-solutions.net>.
The idea is the domain\username is rather harsh for unix systems - people don't
expect to have to FTP, SSH and (in particular) e-mail with a username like
that.
This 'corrects' that - but is not without its own problems.
As you can see from the changes to files like username.c and wb_client.c (smbd's
winbind client code) a lot of assumptions are made in a lot of places about
lp_winbind_seperator determining a users's status as a domain or local user.
The main change I will shortly be making is to investigate and kill off
winbind_initgroups() - as far as I know it was a workaround for an old bug in
winbind itself (and a bug in RH 5.2) and should no longer be relevent.
I am also going to move to using the 'winbind uid' and 'winbind gid' paramaters
to determine a user/groups's 'local' status, rather than the presence of the
seperator.
As such, this functionality is recommended for servers providing unix services,
but is currently less than optimal for windows clients.
(TODO: remove all references to lp_winbind_seperator() and
lp_winbind_use_default_domain() from smbd)
Andrew Bartlett
(This used to be commit 07a21fcd2311d2d9b430b99303e3532a8c1159e4)
Diffstat (limited to 'source3/lib')
| -rw-r--r-- | source3/lib/username.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/lib/username.c b/source3/lib/username.c index 9541ebeb08..7c8c9c740d 100644 --- a/source3/lib/username.c +++ b/source3/lib/username.c @@ -33,7 +33,7 @@ static struct passwd *uname_string_combinations2(char *s, int offset, struct pas BOOL name_is_local(const char *name) { - return !strchr_m(name, *lp_winbind_separator()); + return !(strchr_m(name, *lp_winbind_separator()) || lp_winbind_use_default_domain()); } /**************************************************************************** |