summaryrefslogtreecommitdiff
path: root/source3/libads/kerberos_verify.c
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2008-01-11 23:53:27 -0800
committerJeremy Allison <jra@samba.org>2008-01-11 23:53:27 -0800
commit43717a16e2fca8b196d4a89e33b05fefc0cb02d2 (patch)
treedf7a9e41c0f4e6b91e78a45d5e77ac4796fef54a /source3/libads/kerberos_verify.c
parent866af9a800cbfc022ce6144ee706c0826eb6c39b (diff)
downloadsamba-43717a16e2fca8b196d4a89e33b05fefc0cb02d2.tar.gz
samba-43717a16e2fca8b196d4a89e33b05fefc0cb02d2.tar.bz2
samba-43717a16e2fca8b196d4a89e33b05fefc0cb02d2.zip
Fix CID 476. Ensure a valid pac_data pointer is always passed to
ads_verify_ticket as it's always derefed. Jeremy. (This used to be commit 0599d57efff0f417f75510e8b08c3cb7b4bcfcd8)
Diffstat (limited to 'source3/libads/kerberos_verify.c')
-rw-r--r--source3/libads/kerberos_verify.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/source3/libads/kerberos_verify.c b/source3/libads/kerberos_verify.c
index 7040093e90..5ce7aa6b45 100644
--- a/source3/libads/kerberos_verify.c
+++ b/source3/libads/kerberos_verify.c
@@ -501,8 +501,7 @@ NTSTATUS ads_verify_ticket(TALLOC_CTX *mem_ctx,
DEBUG(3,("ads_verify_ticket: did not retrieve auth data. continuing without PAC\n"));
}
- if (got_auth_data && pac_data != NULL) {
-
+ if (got_auth_data) {
pac_ret = decode_pac_data(mem_ctx, &auth_data, context, keyblock, client_principal, authtime, pac_data);
if (!NT_STATUS_IS_OK(pac_ret)) {
DEBUG(3,("ads_verify_ticket: failed to decode PAC_DATA: %s\n", nt_errstr(pac_ret)));