diff options
| author | Jeremy Allison <jra@samba.org> | 2010-09-15 15:40:15 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2010-09-15 15:40:15 -0700 |
| commit | 447d96878a8b5a335447c37eca2a46b7133caa78 (patch) | |
| tree | e78f895079ee006c6d88f7094be9c41e3df4d3ed /source3/libads | |
| parent | db8cfda320d0e2453d01cdae884fd8aa108bcda7 (diff) | |
| download | samba-447d96878a8b5a335447c37eca2a46b7133caa78.tar.gz samba-447d96878a8b5a335447c37eca2a46b7133caa78.tar.bz2 samba-447d96878a8b5a335447c37eca2a46b7133caa78.zip | |
Fix all sid_parse returns to be checked. Tidy up some checks and error
messages.
Jeremy.
Diffstat (limited to 'source3/libads')
| -rw-r--r-- | source3/libads/ldap.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c index 970f20a8d9..97d89dc88d 100644 --- a/source3/libads/ldap.c +++ b/source3/libads/ldap.c @@ -2145,7 +2145,9 @@ static void dump_sid(ADS_STRUCT *ads, const char *field, struct berval **values) for (i=0; values[i]; i++) { struct dom_sid sid; fstring tmp; - sid_parse(values[i]->bv_val, values[i]->bv_len, &sid); + if (!sid_parse(values[i]->bv_val, values[i]->bv_len, &sid)) { + return; + } printf("%s: %s\n", field, sid_to_fstring(tmp, &sid)); } } |