summaryrefslogtreecommitdiff
path: root/source3/libmsrpc
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2006-03-14 17:21:30 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:15:27 -0500
commite6676a9a6928deb03c2a43a66c1245dd05d03e71 (patch)
tree25f31eac683ccd1082cae2dd37dc9d511000fa67 /source3/libmsrpc
parentbe738dd31dace66f53558b64d6f67828204650aa (diff)
downloadsamba-e6676a9a6928deb03c2a43a66c1245dd05d03e71.tar.gz
samba-e6676a9a6928deb03c2a43a66c1245dd05d03e71.tar.bz2
samba-e6676a9a6928deb03c2a43a66c1245dd05d03e71.zip
r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy. (This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
Diffstat (limited to 'source3/libmsrpc')
-rw-r--r--source3/libmsrpc/libmsrpc_internal.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/source3/libmsrpc/libmsrpc_internal.c b/source3/libmsrpc/libmsrpc_internal.c
index ac61424e70..f57063dc42 100644
--- a/source3/libmsrpc/libmsrpc_internal.c
+++ b/source3/libmsrpc/libmsrpc_internal.c
@@ -100,7 +100,6 @@ RPC_DATA_BLOB *cac_MakeRpcDataBlob(TALLOC_CTX *mem_ctx, uint32 data_type, REG_VA
RPC_DATA_BLOB *blob = NULL;
int i;
uint32 size = 0;
- uint32 len = 0;
uint8 *multi = NULL;
uint32 multi_idx = 0;
@@ -149,7 +148,7 @@ RPC_DATA_BLOB *cac_MakeRpcDataBlob(TALLOC_CTX *mem_ctx, uint32 data_type, REG_VA
/*do it using rpcstr_push()*/
multi_idx = 0;
for(i = 0; i < data.reg_multi_sz.num_strings; i++) {
- len = strlen(data.reg_multi_sz.strings[i]) + 1;
+ size_t len = strlen(data.reg_multi_sz.strings[i]) + 1;
rpcstr_push((multi + multi_idx), data.reg_multi_sz.strings[i], len * 2, STR_TERMINATE);