summaryrefslogtreecommitdiff
path: root/source3/librpc/idl
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2013-08-30 12:49:43 +0000
committerMichael Adam <obnox@samba.org>2013-09-03 17:13:53 +0200
commit7d91ffc6fdc3b371564e14f09822a96264ea372a (patch)
tree7c2534a2c851707e26b66010dfee9b9fc7590d29 /source3/librpc/idl
parent5006db98aaf1efe119f1da8be091587a9bc2b952 (diff)
downloadsamba-7d91ffc6fdc3b371564e14f09822a96264ea372a.tar.gz
samba-7d91ffc6fdc3b371564e14f09822a96264ea372a.tar.bz2
samba-7d91ffc6fdc3b371564e14f09822a96264ea372a.zip
smbd: Fix flawed share_mode_stale_pid API
The comment for this routine said: > Modifies d->num_share_modes, watch out in routines iterating over > that array. Well, it turns out that *every* caller of this API got it wrong. So I think it's better to change the routine. This leaves the array untouched while iterating but filters out the deleted ones while saving them back to disk. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
Diffstat (limited to 'source3/librpc/idl')
-rw-r--r--source3/librpc/idl/open_files.idl6
1 files changed, 6 insertions, 0 deletions
diff --git a/source3/librpc/idl/open_files.idl b/source3/librpc/idl/open_files.idl
index a2e386f68c..686bc02548 100644
--- a/source3/librpc/idl/open_files.idl
+++ b/source3/librpc/idl/open_files.idl
@@ -23,6 +23,12 @@ interface open_files
uint32 uid;
uint16 flags;
uint32 name_hash;
+
+ /*
+ * In-memory flag indicating a non-existing pid. We don't want
+ * to store this share_mode_entry on disk.
+ */
+ [skip] boolean8 stale;
} share_mode_entry;
typedef [public] struct {