summaryrefslogtreecommitdiff
path: root/source3/librpc
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2007-12-15 22:33:52 +0100
committerVolker Lendecke <vl@samba.org>2007-12-15 22:33:52 +0100
commit79cd97cc3f496f781d809c1ab619afa2cc07293d (patch)
tree1fe0611629d29261c9edeb854c94588954baeb2b /source3/librpc
parent4312ad8b98456a59bd5b020d83010695b4baf209 (diff)
downloadsamba-79cd97cc3f496f781d809c1ab619afa2cc07293d.tar.gz
samba-79cd97cc3f496f781d809c1ab619afa2cc07293d.tar.bz2
samba-79cd97cc3f496f781d809c1ab619afa2cc07293d.zip
Use dom_sid_string for sid_string_talloc
Remove some code duplication, but introduce one more dependency on librpc/ndr. Easily turned around so that librpc/ndr depends on lib/util_sid if necessary (This used to be commit 3a0b1b2060facd5f1ac1461b23dd86c75cdd9458)
Diffstat (limited to 'source3/librpc')
-rw-r--r--source3/librpc/ndr/sid.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/source3/librpc/ndr/sid.c b/source3/librpc/ndr/sid.c
index b621f2485b..89ab2b8ea5 100644
--- a/source3/librpc/ndr/sid.c
+++ b/source3/librpc/ndr/sid.c
@@ -75,6 +75,11 @@ char *dom_sid_string(TALLOC_CTX *mem_ctx, const struct dom_sid *sid)
ret = (char *)talloc_size(mem_ctx, maxlen);
if (!ret) return talloc_strdup(mem_ctx, "(SID ERR)");
+ /*
+ * BIG NOTE: this function only does SIDS where the identauth is not
+ * >= ^32 in a range of 2^48.
+ */
+
ia = (sid->id_auth[5]) +
(sid->id_auth[4] << 8 ) +
(sid->id_auth[3] << 16) +