s3-libsmbclient Add comments to describe the behaviour of DEBUG()

This isn't quite what you would expect from this interface, but actually
avoids some really nasty situations if you ever have more than one
libsmbclient context in a process.

In the real world, if you have asked for DEBUG() to stderr in one part
of the code, you will want it globally, even in a different thread
(which in the past would have rest everything to stdout again, at
least while starting up).

Andrew Bartlett

1 files changed, 5 insertions, 3 deletions

diff --git a/source3/libsmb/libsmb_context.c b/source3/libsmb/libsmb_context.c
index 8e76387346..22e0a04717 100644
--- a/source3/libsmb/libsmb_context.c
+++ b/source3/libsmb/libsmb_context.c
@@ -557,9 +557,11 @@ smbc_init_context(SMBCCTX *context)
         
         if (context->internal->debug_stderr) {
             /*
-             * Hmmm... Do we want a unique dbf per-thread? For now, we'll just
-             * leave it up to the user. If any one context spefies debug to
-             * stderr then all will be.
+             * We do not have a unique per-thread debug state? For
+             * now, we'll just leave it up to the user. If any one
+             * context spefies debug to stderr then all will be (and
+             * will stay that way, as it is unsafe to flip back if
+             * stdout is in use for other things)
              */
 	    setup_logging("libsmbclient", DEBUG_STDERR);
         }