Move our NTLMSSP client code into ntlmssp.c. The intention is to provide a

relitivly useful external lib from this code, and to remove the dupicate
NTLMSSP code elsewhere in samba (RPC pipes, LDAP client).

The code I've replaced this with in cliconnect.c is relitivly ugly, and
I hope to replace it with a more general SPENGO layer at some later date.

Andrew Bartlett
(This used to be commit b2b66909ac2e251f8189e0696b6075dbf748521a)

1 files changed, 3 insertions, 3 deletions

diff --git a/source3/libsmb/ntlmssp_parse.c b/source3/libsmb/ntlmssp_parse.c
index 5f3132694e..6644a3db71 100644
--- a/source3/libsmb/ntlmssp_parse.c
+++ b/source3/libsmb/ntlmssp_parse.c
@@ -181,7 +181,7 @@ BOOL msrpc_gen(DATA_BLOB *blob,
 
 /* a helpful macro to avoid running over the end of our blob */
 #define NEED_DATA(amount) \
-if (head_ofs + amount > blob->length) { \
+if ((head_ofs + amount) > blob->length) { \
         return False; \
 }
 
@@ -198,14 +198,14 @@ if (head_ofs + amount > blob->length) { \
   C = constant ascii string
  */
 
-BOOL msrpc_parse(DATA_BLOB *blob,
+BOOL msrpc_parse(const DATA_BLOB *blob,
 		 const char *format, ...)
 {
 	int i;
 	va_list ap;
 	char **ps, *s;
 	DATA_BLOB *b;
-	int head_ofs = 0;
+	size_t head_ofs = 0;
 	uint16 len1, len2;
 	uint32 ptr;
 	uint32 *v;