diff options
| author | Stefan Metzmacher <metze@samba.org> | 2009-04-21 17:42:39 +0200 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2009-04-21 17:42:39 +0200 |
| commit | 14bbed1d6703764e6a58f335f142490895e5c768 (patch) | |
| tree | 4dcf6c9b4b7cab60863b09ebb46fd31a0c3e6388 /source3/libsmb | |
| parent | 7a0a134e0cc0720402b2e07ee8bc9887ce8e8c5d (diff) | |
| download | samba-14bbed1d6703764e6a58f335f142490895e5c768.tar.gz samba-14bbed1d6703764e6a58f335f142490895e5c768.tar.bz2 samba-14bbed1d6703764e6a58f335f142490895e5c768.zip | |
s3:libsmb: always use the tevent_req_nomem() for checking allocation failures
This will also make sure we cleanup 'req' in case of an error.
metze
Diffstat (limited to 'source3/libsmb')
| -rw-r--r-- | source3/libsmb/clifile.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c index f5d5ad0fda..1a1153d546 100644 --- a/source3/libsmb/clifile.c +++ b/source3/libsmb/clifile.c @@ -622,8 +622,8 @@ struct tevent_req *cli_mkdir_send(TALLOC_CTX *mem_ctx, } bytes = talloc_array(state, uint8_t, 1); - if (!bytes) { - return NULL; + if (tevent_req_nomem(bytes, req)) { + return tevent_req_post(req, ev); } bytes[0] = 4; bytes = smb_bytes_push_str(bytes, cli_ucs2(cli), dname, @@ -634,7 +634,7 @@ struct tevent_req *cli_mkdir_send(TALLOC_CTX *mem_ctx, } subreq = cli_smb_send(state, ev, cli, SMBmkdir, additional_flags, - 0, NULL, talloc_get_size(bytes), bytes); + 0, NULL, talloc_get_size(bytes), bytes); if (tevent_req_nomem(subreq, req)) { return tevent_req_post(req, ev); } @@ -730,8 +730,8 @@ struct tevent_req *cli_rmdir_send(TALLOC_CTX *mem_ctx, } bytes = talloc_array(state, uint8_t, 1); - if (!bytes) { - return NULL; + if (tevent_req_nomem(bytes, req)) { + return tevent_req_post(req, ev); } bytes[0] = 4; bytes = smb_bytes_push_str(bytes, cli_ucs2(cli), dname, @@ -742,7 +742,7 @@ struct tevent_req *cli_rmdir_send(TALLOC_CTX *mem_ctx, } subreq = cli_smb_send(state, ev, cli, SMBrmdir, additional_flags, - 0, NULL, talloc_get_size(bytes), bytes); + 0, NULL, talloc_get_size(bytes), bytes); if (tevent_req_nomem(subreq, req)) { return tevent_req_post(req, ev); } |