diff options
| author | Jeremy Allison <jra@samba.org> | 2009-06-01 14:36:34 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2009-06-01 14:38:56 -0700 |
| commit | cdb765a76caaa582b6406bd34279d04e4be9d6f2 (patch) | |
| tree | f9d463cd9bf78c3a7fe81366e4bbd9a27906deef /source3/libsmb | |
| parent | 50043177e842f791d33b52c1fca8be13682a0e0b (diff) | |
| download | samba-cdb765a76caaa582b6406bd34279d04e4be9d6f2.tar.gz samba-cdb765a76caaa582b6406bd34279d04e4be9d6f2.tar.bz2 samba-cdb765a76caaa582b6406bd34279d04e4be9d6f2.zip | |
Fix bug #6419 - smbclient -L 127.0.0.1" displays "netbios name" instead of "workgroup"
Unify the handling of the sessionsetup parsing so we don't get different
results when parsing a guest reply than an ntlmssp reply.
Jeremy.
Diffstat (limited to 'source3/libsmb')
| -rw-r--r-- | source3/libsmb/cliconnect.c | 29 |
1 files changed, 26 insertions, 3 deletions
diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c index 16c15ce7db..772661103b 100644 --- a/source3/libsmb/cliconnect.c +++ b/source3/libsmb/cliconnect.c @@ -671,9 +671,30 @@ static DATA_BLOB cli_session_setup_blob_receive(struct cli_state *cli) /* w2k with kerberos doesn't properly null terminate this field */ len = smb_bufrem(cli->inbuf, p); - p += clistr_pull(cli->inbuf, cli->server_type, p, sizeof(fstring), - len, 0); + if (p + len < cli->inbuf + cli->bufsize+SAFETY_MARGIN - 2) { + char *end_of_buf = p + len; + SSVAL(p, len, 0); + /* Now it's null terminated. */ + p += clistr_pull(cli->inbuf, cli->server_type, p, sizeof(fstring), + -1, STR_TERMINATE); + /* + * See if there's another string. If so it's the + * server domain (part of the 'standard' Samba + * server signature). + */ + if (p < end_of_buf) { + p += clistr_pull(cli->inbuf, cli->server_domain, p, sizeof(fstring), + -1, STR_TERMINATE); + } + } else { + /* + * No room to null terminate so we can't see if there + * is another string (server_domain) afterwards. + */ + p += clistr_pull(cli->inbuf, cli->server_type, p, sizeof(fstring), + len, 0); + } return blob2; } @@ -918,7 +939,9 @@ static NTSTATUS cli_session_setup_ntlmssp(struct cli_state *cli, const char *use if (NT_STATUS_IS_OK(nt_status)) { - fstrcpy(cli->server_domain, ntlmssp_state->server_domain); + if (cli->server_domain[0] == '\0') { + fstrcpy(cli->server_domain, ntlmssp_state->server_domain); + } cli_set_session_key(cli, ntlmssp_state->session_key); if (cli_simple_set_signing( |