summaryrefslogtreecommitdiff
path: root/source3/locking
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2001-08-27 17:52:23 +0000
committerAndrew Tridgell <tridge@samba.org>2001-08-27 17:52:23 +0000
commitee5f7237decfe446f4fdb08422beb2e6cb43af7f (patch)
tree80b217a2938d7e0d46a5d20517c9adb0807ecd1a /source3/locking
parente8e98c9ea0690e3acf1126b50882e59e1056c7b3 (diff)
downloadsamba-ee5f7237decfe446f4fdb08422beb2e6cb43af7f.tar.gz
samba-ee5f7237decfe446f4fdb08422beb2e6cb43af7f.tar.bz2
samba-ee5f7237decfe446f4fdb08422beb2e6cb43af7f.zip
started converting NTSTATUS to be a structure on systems with gcc in order to make it type incompatible with BOOL so we catch errors sooner. This has already found a number of bugs
(This used to be commit 1b778bc7d22efff3f90dc450eb12baa1241cf68f)
Diffstat (limited to 'source3/locking')
-rw-r--r--source3/locking/locking.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/source3/locking/locking.c b/source3/locking/locking.c
index d6915140a5..e905bd56e9 100644
--- a/source3/locking/locking.c
+++ b/source3/locking/locking.c
@@ -105,7 +105,7 @@ NTSTATUS do_lock(files_struct *fsp,connection_struct *conn, uint16 lock_pid,
BOOL ok = False;
if (!lp_locking(SNUM(conn)))
- return NT_STATUS_NOPROBLEMO;
+ return NT_STATUS(0);
/* NOTE! 0 byte long ranges ARE allowed and should be stored */
@@ -156,10 +156,10 @@ NTSTATUS do_unlock(files_struct *fsp,connection_struct *conn, uint16 lock_pid,
BOOL ok = False;
if (!lp_locking(SNUM(conn)))
- return NT_STATUS_NOPROBLEMO;
+ return NT_STATUS(0);
if (!OPEN_FSP(fsp) || !fsp->can_lock || (fsp->conn != conn)) {
- return NT_STATUS_INVALID_HANDLE;
+ return NT_STATUS(NT_STATUS_INVALID_HANDLE);
}
DEBUG(10,("do_unlock: unlock start=%.0f len=%.0f requested for file %s\n",
@@ -176,15 +176,15 @@ NTSTATUS do_unlock(files_struct *fsp,connection_struct *conn, uint16 lock_pid,
if (!ok) {
DEBUG(10,("do_unlock: returning ERRlock.\n" ));
- return NT_STATUS_LOCK_NOT_GRANTED;
+ return NT_STATUS(NT_STATUS_LOCK_NOT_GRANTED);
}
if (!lp_posix_locking(SNUM(conn)))
- return NT_STATUS_NOPROBLEMO;
+ return NT_STATUS(0);
(void)release_posix_lock(fsp, offset, count);
- return NT_STATUS_NOPROBLEMO; /* Did unlock */
+ return NT_STATUS(0);
}
/****************************************************************************