summaryrefslogtreecommitdiff
path: root/source3/modules
diff options
context:
space:
mode:
authortprouty <tprouty@b72e2a10-2d34-0410-9a71-d3beadf02b57>2009-05-02 00:28:38 +0000
committerTim Prouty <tprouty@samba.org>2009-05-05 16:43:53 -0700
commit69d61453df6019caef4e7960fa78c6a3c51f3d2a (patch)
tree406d028c81bc1bf0f33507c00c5f0da7a83cf984 /source3/modules
parente091fdc5658e65be290ebb3b62a1bdf517781a65 (diff)
downloadsamba-69d61453df6019caef4e7960fa78c6a3c51f3d2a.tar.gz
samba-69d61453df6019caef4e7960fa78c6a3c51f3d2a.tar.bz2
samba-69d61453df6019caef4e7960fa78c6a3c51f3d2a.zip
s3: Fix trans2 path to use case-insensitive stat optimization
Often times before creating a file, a client will first query to see if it already exists. Since some systems have a case-insensitive stat that is called from unix_convert, we can definitively return STATUS_NO_SUCH_FILE to the client without scanning the whole directory. This code path is taken from trans2querypathinfo, but trans2findfirst still does a full directory scan even though the get_real_filename (the case-insensitive stat vfs call) can prevent this. This patch adds the get_real_filename call to the trans2find* path, and also changes the vfs_default behavior for SMB_VFS_GET_REAL_FILENAME. Previously, in the absence of a get_real_filename implementation, we would fallback to the full directory scan. The default behavior now returns -1 and sets errno to EOPNOTSUPP. This allows SMB_VFS_GET_REALFILENAME to be called from trans2* and unix_convert.
Diffstat (limited to 'source3/modules')
-rw-r--r--source3/modules/vfs_default.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c
index bb01f98588..6c1946a99d 100644
--- a/source3/modules/vfs_default.c
+++ b/source3/modules/vfs_default.c
@@ -1120,8 +1120,12 @@ static int vfswrap_get_real_filename(struct vfs_handle_struct *handle,
TALLOC_CTX *mem_ctx,
char **found_name)
{
- return get_real_filename(handle->conn, path, name, mem_ctx,
- found_name);
+ /*
+ * Don't fall back to get_real_filename so callers can differentiate
+ * between a full directory scan and an actual case-insensitive stat.
+ */
+ errno = EOPNOTSUPP;
+ return -1;
}
static NTSTATUS vfswrap_brl_lock_windows(struct vfs_handle_struct *handle,