summaryrefslogtreecommitdiff
path: root/source3/nmbd
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2002-03-20 06:57:03 +0000
committerMartin Pool <mbp@samba.org>2002-03-20 06:57:03 +0000
commit75722fa183d1678bc7360bc79f9ac8cf17cd62e3 (patch)
treee0d46b5c43e731ddba89fb1e632ccef081e100ad /source3/nmbd
parenta17b5158f1fad6702187afcd1c39684eb4d2ed34 (diff)
downloadsamba-75722fa183d1678bc7360bc79f9ac8cf17cd62e3.tar.gz
samba-75722fa183d1678bc7360bc79f9ac8cf17cd62e3.tar.bz2
samba-75722fa183d1678bc7360bc79f9ac8cf17cd62e3.zip
Add assertions that kill() is never accidentally passed a non-positive
pid. This follows a bug in rsync where it would accidentally kill(-1), removing all the user's processes. I can't see any way this would directly happen in Samba, but having the assertions seems beneficial. http://cvs.samba.org/cgi-bin/cvsweb/rsync/util.c.diff?r1=1.108&r2=1.109&f=h (This used to be commit 098905bea29c7d5b886809d431294ddf2fc1e152)
Diffstat (limited to 'source3/nmbd')
-rw-r--r--source3/nmbd/asyncdns.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/nmbd/asyncdns.c b/source3/nmbd/asyncdns.c
index c5ff718836..6c2f8de3b1 100644
--- a/source3/nmbd/asyncdns.c
+++ b/source3/nmbd/asyncdns.c
@@ -120,8 +120,9 @@ static void sig_term(int sig)
void kill_async_dns_child(void)
{
- if(child_pid != 0 && child_pid != -1)
- kill(child_pid, SIGTERM);
+ if (child_pid > 0) {
+ kill(child_pid, SIGTERM);
+ }
}
/***************************************************************************