finally got sick of the "extern int Client" code and the stupid

assumption that we have one socket everywhere

while doing so I discovered a few bugs!

1) the clientgen session retarget code if used from smbd or nmbd would
cause a crash as it called close_sockets() which closed our main
socket! fixed by removing close_sockets() completely - it is unnecessary

2) the caching in client_addr() and client_name() was bogus - it could
easily get fooled and give the wrong result. fixed.

3) the retarget could could recurse, allowing an easy denial of
service attack on nmbd. fixed.
(This used to be commit 5937ab14d222696e40a3fc6f0e6a536f2d7305d3)

1 files changed, 0 insertions, 1 deletions

diff --git a/source3/nmbd/nmbd.c b/source3/nmbd/nmbd.c
index 57d025c660..c7ebe48822 100644
--- a/source3/nmbd/nmbd.c
+++ b/source3/nmbd/nmbd.c
@@ -859,7 +859,6 @@ static void usage(char *pname)
 #endif /* SIGUSR2 */
 
   process();
-  close_sockets();
 
   if (dbf)
     fclose(dbf);