Fix for crash when doing name lookup with a quoted string. Part of

lookup_name was expecting to be able to write to the string. Changed
lookup_name to use const.
Jeremy.
(This used to be commit 80c18d88491f1148ade623e81c33f84ba4f952f3)

1 files changed, 11 insertions, 1 deletions

diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c
index 2b318eca53..918fdcd088 100644
--- a/source3/passdb/passdb.c
+++ b/source3/passdb/passdb.c
@@ -504,11 +504,21 @@ BOOL local_lookup_rid(uint32 rid, char *name, enum SID_NAME_USE *psid_name_use)
  Convert a name into a SID. Used in the lookup name rpc.
  ********************************************************************/
 
-BOOL local_lookup_name(char *domain, char *user, DOM_SID *psid, enum SID_NAME_USE *psid_name_use)
+BOOL local_lookup_name(const char *c_domain, const char *c_user, DOM_SID *psid, enum SID_NAME_USE *psid_name_use)
 {
 	extern DOM_SID global_sid_World_Domain;
 	struct passwd *pass = NULL;
 	DOM_SID local_sid;
+	fstring user;
+	fstring domain;
+
+	/*
+	 * domain and user may be quoted const strings, and map_username and
+	 * friends can modify them. Make a modifiable copy. JRA.
+	 */
+
+	fstrcpy(domain, c_domain);
+	fstrcpy(user, c_user);
 
 	sid_copy(&local_sid, &global_sam_sid);