diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2003-02-17 12:27:34 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2003-02-17 12:27:34 +0000 |
| commit | cc0202884b1023059769450a4a052431ab362e78 (patch) | |
| tree | 38df576fcbb01e20dfff0fac3e11bd9b399d3131 /source3/printing/nt_printing.c | |
| parent | af249535bd8c17e38d5de05352d36747da67e551 (diff) | |
| download | samba-cc0202884b1023059769450a4a052431ab362e78.tar.gz samba-cc0202884b1023059769450a4a052431ab362e78.tar.bz2 samba-cc0202884b1023059769450a4a052431ab362e78.zip | |
This patch fixes one of my longest-standing pet hates with Samba :-).
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.
I'm sure this will fix some nasty performance issues, particularly on large
domains etc. In particular, this avoids contacting winbind at all, if the
group is not a winbind group.
(This caused a deadlock on my winbind-on-PDC setup).
The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.
Andrew Bartlett
(This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
Diffstat (limited to 'source3/printing/nt_printing.c')
| -rw-r--r-- | source3/printing/nt_printing.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c index 10d490a4c1..836324ecc9 100644 --- a/source3/printing/nt_printing.c +++ b/source3/printing/nt_printing.c @@ -4734,7 +4734,7 @@ BOOL print_access_check(struct current_user *user, int snum, int access_type) /* Always allow root or printer admins to do anything */ if (user->uid == 0 || - user_in_list(uidtoname(user->uid), lp_printer_admin(snum))) { + user_in_list(uidtoname(user->uid), lp_printer_admin(snum), user->groups, user->ngroups)) { return True; } |