diff options
| author | Volker Lendecke <vl@samba.org> | 2009-03-01 11:39:44 +0100 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2009-03-01 12:27:55 +0100 |
| commit | 4a35c974e97551b1ccbfa41d4c08f0598e3c26aa (patch) | |
| tree | 0b4be816a1cfef54cada3a5c0d4530f9960ddbf1 /source3/printing/printing.c | |
| parent | 79fc0ddaf44af1e31d7e6f2c6f576fd3c05e087d (diff) | |
| download | samba-4a35c974e97551b1ccbfa41d4c08f0598e3c26aa.tar.gz samba-4a35c974e97551b1ccbfa41d4c08f0598e3c26aa.tar.bz2 samba-4a35c974e97551b1ccbfa41d4c08f0598e3c26aa.zip | |
Only copy sharename up from rap_to_pjobid
Why?? :-)
Another one of the little micro-optimizations that I just came across: If you
allocate a variable in a sub-block like the "fstring sharename" in
write_file(), gcc even with -O3 will allocate this variable unconditionally on
the stack at the beginning of the routine. So with eliminating this fstring we
cut 256 bytes of stack in a very hot code path writing to a file. It might make
us a bit more cache-friendly.
This would probably not be worth a second look if it involved larger code
changes, but this one was just too simple to let it pass :-)
Diffstat (limited to 'source3/printing/printing.c')
| -rw-r--r-- | source3/printing/printing.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source3/printing/printing.c b/source3/printing/printing.c index 49bd5ac8ba..fc3667ea3a 100644 --- a/source3/printing/printing.c +++ b/source3/printing/printing.c @@ -117,7 +117,9 @@ bool rap_to_pjobid(uint16 rap_jobid, fstring sharename, uint32 *pjobid) if ( data.dptr && data.dsize == sizeof(struct rap_jobid_key) ) { struct rap_jobid_key *jinfo = (struct rap_jobid_key*)data.dptr; - fstrcpy( sharename, jinfo->sharename ); + if (sharename != NULL) { + fstrcpy( sharename, jinfo->sharename ); + } *pjobid = jinfo->jobid; DEBUG(10,("rap_to_pjobid: jobid %u maps to RAP jobid %u\n", (unsigned int)*pjobid, (unsigned int)rap_jobid)); |