diff options
| author | Jeremy Allison <jra@samba.org> | 2000-06-01 21:00:37 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2000-06-01 21:00:37 +0000 |
| commit | b9fedcb2de5612bdb4e763fe0788e1a4a9c16d33 (patch) | |
| tree | 088f062c58a4fe3d5a57b98b279ae8bf97bf2cb5 /source3/printing | |
| parent | 61ab5b46cfb93939651b4426016845a035315bf7 (diff) | |
| download | samba-b9fedcb2de5612bdb4e763fe0788e1a4a9c16d33.tar.gz samba-b9fedcb2de5612bdb4e763fe0788e1a4a9c16d33.tar.bz2 samba-b9fedcb2de5612bdb4e763fe0788e1a4a9c16d33.zip | |
param/loadparm.c: Looks like someone ran indent on this !
passdb/smbpass.c: Insure uninitialized memory reference fix.
printing/nt_printing.c:
rpc_server/srv_spoolss_nt.c: Insure memory leak fixes.
smbd/unix_acls.c: Shadow ref fix.
Jeremy.
(This used to be commit d175d3ebefc053e9badd91ca5f2d8bd03eb6705d)
Diffstat (limited to 'source3/printing')
| -rw-r--r-- | source3/printing/nt_printing.c | 20 |
1 files changed, 15 insertions, 5 deletions
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c index 023f4ce9d1..de3b9ed6c5 100644 --- a/source3/printing/nt_printing.c +++ b/source3/printing/nt_printing.c @@ -362,7 +362,9 @@ static uint32 get_a_printer_driver_3_default(NT_PRINTER_DRIVER_INFO_LEVEL_3 **in fstrcpy(info.name, lp_printerdriver(snum)); fstrcpy(info.defaultdatatype, "RAW"); - info.dependentfiles=(fstring *)malloc(sizeof(fstring)); + if ((info.dependentfiles=(char *)malloc(sizeof(fstring))) == NULL) + return ERROR_NOT_ENOUGH_MEMORY; + fstrcpy(info.dependentfiles[0], ""); *info_ptr = memdup(&info, sizeof(info)); @@ -407,15 +409,22 @@ static uint32 get_a_printer_driver_3(NT_PRINTER_DRIVER_INFO_LEVEL_3 **info_ptr, while (len < dbuf.dsize) { driver.dependentfiles = (fstring *)Realloc(driver.dependentfiles, sizeof(fstring)*(i+2)); + if (driver.dependentfiles == NULL) + break; + len += tdb_unpack(dbuf.dptr+len, dbuf.dsize-len, "f", - driver.dependentfiles[i]); + &driver.dependentfiles[i]); i++; } - fstrcpy(driver.dependentfiles[i], ""); + if (driver.dependentfiles != NULL) + fstrcpy(driver.dependentfiles[i], ""); safe_free(dbuf.dptr); if (len != dbuf.dsize) { + if (driver.dependentfiles != NULL) + safe_free(driver.dependentfiles); + return get_a_printer_driver_3_default(info_ptr, in_prt, in_arch); } @@ -1155,6 +1164,8 @@ uint32 get_a_printer(NT_PRINTER_INFO_LEVEL **pp_printer, uint32 level, fstring s if (success == 0) { dump_a_printer(*printer, level); *pp_printer = printer; + } else { + safe_free(printer); } break; } @@ -1274,8 +1285,7 @@ uint32 free_a_printer_driver(NT_PRINTER_DRIVER_INFO_LEVEL driver, uint32 level) if (driver.info_3 != NULL) { info3=driver.info_3; - if (info3->dependentfiles) - free(info3->dependentfiles); + safe_free(info3->dependentfiles); safe_free(info3); ZERO_STRUCTP(info3); success=0; |