diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2003-01-02 09:07:17 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2003-01-02 09:07:17 +0000 |
| commit | 6d66fb308ab85bd9691d541764e683e6040cf724 (patch) | |
| tree | 10b705921665cb7bafdd332ca53b8a943e13f0e5 /source3/registry | |
| parent | c105c12d122e599fe57dde8b2b73c52231f0c1d2 (diff) | |
| download | samba-6d66fb308ab85bd9691d541764e683e6040cf724.tar.gz samba-6d66fb308ab85bd9691d541764e683e6040cf724.tar.bz2 samba-6d66fb308ab85bd9691d541764e683e6040cf724.zip | |
BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
Diffstat (limited to 'source3/registry')
| -rw-r--r-- | source3/registry/reg_objects.c | 4 | ||||
| -rw-r--r-- | source3/registry/reg_printing.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/source3/registry/reg_objects.c b/source3/registry/reg_objects.c index 3289ebfe88..9cfeb7faa9 100644 --- a/source3/registry/reg_objects.c +++ b/source3/registry/reg_objects.c @@ -40,7 +40,7 @@ void regsubkey_ctr_init( REGSUBKEY_CTR *ctr ) Add a new key to the array **********************************************************************/ -int regsubkey_ctr_addkey( REGSUBKEY_CTR *ctr, char *keyname ) +int regsubkey_ctr_addkey( REGSUBKEY_CTR *ctr, const char *keyname ) { uint32 len; char **pp; @@ -345,7 +345,7 @@ int regval_ctr_delvalue( REGVAL_CTR *ctr, const char *name ) No need to free memory since it is talloc'd. **********************************************************************/ -REGISTRY_VALUE* regval_ctr_getvalue( REGVAL_CTR *ctr, char *name ) +REGISTRY_VALUE* regval_ctr_getvalue( REGVAL_CTR *ctr, const char *name ) { int i; diff --git a/source3/registry/reg_printing.c b/source3/registry/reg_printing.c index a58a91a0a8..4b8eaa658e 100644 --- a/source3/registry/reg_printing.c +++ b/source3/registry/reg_printing.c @@ -84,7 +84,7 @@ static char* trim_reg_path( char *path ) static int print_subpath_environments( char *key, REGSUBKEY_CTR *subkeys ) { - char *environments[] = { + const char *environments[] = { "Windows 4.0", "Windows NT x86", "Windows NT R4000", |