diff options
| author | Tim Potter <tpot@samba.org> | 2001-10-31 04:42:16 +0000 |
|---|---|---|
| committer | Tim Potter <tpot@samba.org> | 2001-10-31 04:42:16 +0000 |
| commit | d607fe04743b6ca20172d3a4156e5fa855054e99 (patch) | |
| tree | d308cc9cc8680ba27b35784b7eff74dc30f8a2f4 /source3/rpc_client | |
| parent | 3e2f355a2ed4b372585d259839ff67d20e5d61d1 (diff) | |
| download | samba-d607fe04743b6ca20172d3a4156e5fa855054e99.tar.gz samba-d607fe04743b6ca20172d3a4156e5fa855054e99.tar.bz2 samba-d607fe04743b6ca20172d3a4156e5fa855054e99.zip | |
Don't accidentally return success when sending a broken NET_SAMLOGON
request. This exposes a domain authentication bug with win2k where a rpc
fault is returned but not propagated up as an error.
(This used to be commit 27cd7ac85779bbc1e9488ee06e87b0c743c5b29c)
Diffstat (limited to 'source3/rpc_client')
| -rw-r--r-- | source3/rpc_client/cli_netlogon.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/rpc_client/cli_netlogon.c b/source3/rpc_client/cli_netlogon.c index 50f68e19f0..c18d2ae23d 100644 --- a/source3/rpc_client/cli_netlogon.c +++ b/source3/rpc_client/cli_netlogon.c @@ -378,6 +378,7 @@ static NTSTATUS cli_net_sam_logon_internal(struct cli_state *cli, NET_ID_INFO_CT /* send the data on \PIPE\ */ if (!rpc_api_pipe_req(cli, NET_SAMLOGON, &buf, &rbuf)) { DEBUG(0,("cli_net_sam_logon_internal: Error rpc_api_pipe_req failed.\n")); + retval = NT_STATUS_UNSUCCESSFUL; goto out; } |