summaryrefslogtreecommitdiff
path: root/source3/rpc_parse
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2000-08-28 04:42:31 +0000
committerAndrew Tridgell <tridge@samba.org>2000-08-28 04:42:31 +0000
commit9e1f9a5719315aaa9b184fc5b0a750c68fbd8941 (patch)
tree736a30deb469db48b63c639f914b9e9b66923e5c /source3/rpc_parse
parent4ff15c319eb70396f2534fb8c165b7f71c58b311 (diff)
downloadsamba-9e1f9a5719315aaa9b184fc5b0a750c68fbd8941.tar.gz
samba-9e1f9a5719315aaa9b184fc5b0a750c68fbd8941.tar.bz2
samba-9e1f9a5719315aaa9b184fc5b0a750c68fbd8941.zip
yipee!
The spoolss AddJob function has an [in,out] buffer not an [in] buffer (despite the comment in the code to the contrary). Also, we must fail this function - not just blindly reply "no problem" as AddJob should always fail on non-local printers. This fixes a bug where the "print test page" failed about half the time. I suspect it will also fix a bunch of other intermittent spoolss bugs where the client (incorrectly) tries to use the AddJob printing interface. (This used to be commit 14e534a8907c34b53e00a63756efd71903ff9432)
Diffstat (limited to 'source3/rpc_parse')
-rw-r--r--source3/rpc_parse/parse_spoolss.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index 5598c619a9..54794a7343 100644
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -3291,6 +3291,15 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
if(!prs_align(ps))
return False;
+ if(!new_spoolss_io_buffer("", ps, depth, r_u->buffer))
+ return False;
+
+ if(!prs_align(ps))
+ return False;
+
+ if(!prs_uint32("needed", ps, depth, &r_u->needed))
+ return False;
+
if(!prs_uint32("status", ps, depth, &r_u->status))
return False;