diff options
| author | Jeremy Allison <jra@samba.org> | 2006-06-15 01:54:09 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:17:27 -0500 |
| commit | f9147c4e408d316d194c4e367dfccbf433cb8ec9 (patch) | |
| tree | c706add179942ab8c6b54cda49e9b0a47fc69bca /source3/rpc_parse | |
| parent | a1e0a0e9286fbe90ca04cda9df38e72d8d18b0c1 (diff) | |
| download | samba-f9147c4e408d316d194c4e367dfccbf433cb8ec9.tar.gz samba-f9147c4e408d316d194c4e367dfccbf433cb8ec9.tar.bz2 samba-f9147c4e408d316d194c4e367dfccbf433cb8ec9.zip | |
r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
Diffstat (limited to 'source3/rpc_parse')
0 files changed, 0 insertions, 0 deletions