summaryrefslogtreecommitdiff
path: root/source3/rpc_server
diff options
context:
space:
mode:
authorGünther Deschner <gd@samba.org>2009-02-20 14:55:31 +0100
committerGünther Deschner <gd@samba.org>2009-02-21 21:14:20 +0100
commitd3372c6a9e69360afd2f12168e9df09dec45ae08 (patch)
treeb9dac5e82af668ba78a9fe5539caa272823ae09f /source3/rpc_server
parent762b92e285b7d98936393fc61a5ab18c66e9d534 (diff)
downloadsamba-d3372c6a9e69360afd2f12168e9df09dec45ae08.tar.gz
samba-d3372c6a9e69360afd2f12168e9df09dec45ae08.tar.bz2
samba-d3372c6a9e69360afd2f12168e9df09dec45ae08.zip
s3-spoolss: fix _spoolss_GetPrinterDriverDirectory and spoolss_GetPrintProcessorDirectory.
Both calls need to return NULL in the error case to avoid ndr encoding problems. (found by smbtorture spoolss test). Guenther
Diffstat (limited to 'source3/rpc_server')
-rw-r--r--source3/rpc_server/srv_spoolss_nt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
index 7439fe51a5..0fe66d9ed9 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -8309,7 +8309,7 @@ WERROR _spoolss_GetPrinterDriverDirectory(pipes_struct *p,
&r->out.info->info1,
r->in.offered,
r->out.needed);
- if (W_ERROR_EQUAL(werror, WERR_INSUFFICIENT_BUFFER)) {
+ if (!W_ERROR_IS_OK(werror)) {
TALLOC_FREE(r->out.info);
}
break;
@@ -9969,7 +9969,7 @@ WERROR _spoolss_GetPrintProcessorDirectory(pipes_struct *p,
&r->out.info->info1,
r->in.offered,
r->out.needed);
- if (W_ERROR_EQUAL(result, WERR_INSUFFICIENT_BUFFER)) {
+ if (!W_ERROR_IS_OK(result)) {
TALLOC_FREE(r->out.info);
}
break;