summaryrefslogtreecommitdiff
path: root/source3/samba4-templates.mk
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-08-17 22:45:51 +1000
committerAndrew Tridgell <tridge@samba.org>2009-08-17 22:46:47 +1000
commit1b09e36f0bc1942a5156715db21aed1ad403800e (patch)
tree2167f2f90527e359f06da88ed94cbb3a7ff63911 /source3/samba4-templates.mk
parent6cc9e4b9006e3f10ff88d20ecd0dd26c2fa63611 (diff)
downloadsamba-1b09e36f0bc1942a5156715db21aed1ad403800e.tar.gz
samba-1b09e36f0bc1942a5156715db21aed1ad403800e.tar.bz2
samba-1b09e36f0bc1942a5156715db21aed1ad403800e.zip
fixed make test reporting success when provision fails
We were getting build test 'pass' on the build farm when the provision is failing. The cause was the use of filter pipelines in the selftest code in the makefile. A bourne shell will by default report the error status of the last element of the pipeline, which means when provision failed, make thought everything had passed. We could use the bash 'pipefail' option to fix this, but it isn't portable, so instead I've modified the makefile to touch st/st_done when the first element in the pipeline completes successfully. That means we now get errors in make test, at the expense of making the makefile even more horrible than it was.
Diffstat (limited to 'source3/samba4-templates.mk')
0 files changed, 0 insertions, 0 deletions